New LdapService.authenticate() API + TLS support
#384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Use TLS security/encryption in Apache Library
cnrudd
reviewed
Aug 22, 2024
| * This method uses the underlying LDAP bind mechanism to verify user password and access. | ||
| * | ||
| * @param username -- sAMAccountName for user | ||
| * @param password -- credentials for user |
There was a problem hiding this comment.
just a nit: "credentials" makes me wonder right away that more than one thing is expected.
can the doc say: "user's AD password"
| ret.useTls = true | ||
| if (config.requireCert == false) { | ||
| ret.setTrustManagers(new NoVerificationTrustManager()) | ||
| } |
There was a problem hiding this comment.
As discussed with Lee, I will explore using a trust store here.
amcclain
changed the title
LdapService.authenticate() API + TLS support
+ Wanted a more explicit / clear name for this flag, using term "verification" to match use of `NoVerificationTrustManager`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authenticate method is provided as support for a Forms based (backup) authentication directly against local AD
Re: TLS secured connection, which is orthogonal