Unpin Logback version #279
Conversation
There was a problem hiding this comment.
Apols for letting this linger for so long w/o comment. Ryan just ran into this while updating a Hoist app - needed to add the magic logback.version=1.2.7 to gradle.properties.
Not a big hassle, but one more bit of boilerplate spread across apps, and the kind of thing that will likely get caught in various scans, etc. going forward. So am motivated to merge if we have a look at the latest from dogbert and determine it's all working as expected.
| * v16 restores the use of the standard grails version of logback (v1.2.11). Hoist had been | ||
| pinned on an earlier version of logback due to dropped support of groovy based configuration. | ||
| This support is now restored via plugin. This change will require renaming the | ||
| `conf/logback.groovy` file in your application to `conf/logback-config.groovy`. It also may |
There was a problem hiding this comment.
Note that this is no longer the case - can stick with logback.groovy as per updated dogbert docs.
There was a problem hiding this comment.
Unfortunately, not that simple (see below)
| @@ -76,6 +76,7 @@ dependencies { | |||
| api 'org.jasypt:jasypt:1.9.3' | |||
| api "commons-io:commons-io:2.8.0" | |||
| api "org.owasp.encoder:encoder:1.2.3" | |||
| implementation 'io.github.virtualdogbert:logback-groovy-config:1.0' | |||
There was a problem hiding this comment.
There are now different versions of this library depending on the particular minor version of logback we're looking to take.
|
(Happy to try to make the updates to the library version and tweak this PR - figured we could decide if we have any interest in doing that before the big multi-instance merge, or not) |
|
I looked at this a month or two back, but was frustrated to see that grails was still on a newer, but not latest version of logback. That version would require apps to rename the Chatted with the author of the plugin (formerly known as virtualdogbert, now groovyduke) and he suggested we wait until grails upgrades logback to the latest. |
We can take this now, but note that it will require our applications to rename their
logback.groovyfiles. There might need to be an additional rename back tologback.groovyin the future, which would be annoying.Alternatively we could wait a tick, untils grails upgrades to the lastest version of logback, and it looks like then the file rename would not be needed. Guess it depends on how anxious we are to unping logback.groovy.
See matching toolbox branch here
xh/toolbox#644