Link #577
Merged
Link #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinhtranchau
added a commit
to vinhtranchau/jodit-repo
that referenced
this pull request
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Sorry, I don't speak French well (Thanks Google Translate).
It's also my first time on GitHub, my first Pull Requeqst, my first participation to another's project, my first TypeScript code, ...
This Pull Request is not a bug fix but a new feature :
Added the possibility to add a "class" attribute on the "" tags.
There are several options to indicate how to enter the value of this attribute: input text or dropdown list, multiple value possible or not, ...
I wrote the acceptance tests and added the documentation of the new options.
Just a little problem : 2 tests fail but I have the impression that this is not due to my modifications.
And I couldn't fix that.
It'a about the link.formTemplate option !
If this Pull Request is accepted, I'm thinking of delivering others in a row to add similar things on other tags.
Let me know if you would be interested!