Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcp.pm fix #6539

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dhcp.pm fix #6539

wants to merge 1 commit into from

Conversation

po1vo
Copy link

@po1vo po1vo commented Jan 17, 2020

dhcp.pm claimed to not add ip address of a node, overlapping with dhcp dynamic range, but added anyway

@gurevichmark
Copy link
Contributor

@po1vo Thank you for the contribution.
Can you please post how this problem can be recreated ?

@po1vo
Copy link
Author

po1vo commented Jan 17, 2020

  1. Pick an IP from a network dynamic dhcp range.
  2. Pick a node and set the node's hosts.ip to the IP from the first step.
  3. Do makedhcp node and see a message:

"The ip address $ip of node $node overlaps with the DHCP dynamic range specified in networks table, will not add this ip address into dhcpd.leases file."

But the address is added to dhcpd.leases anyway

@samveen
Copy link
Member

samveen commented Jan 24, 2020

This has the potential to break existing installations of xCAT (especially badly designed ones, like my early efforts) . A release note/warning in the next version would be a good idea if this is merged.

@gurevichmark
Copy link
Contributor

@samveen Can you elaborate under which conditions this PR will be a problem ?

@gurevichmark gurevichmark self-requested a review June 3, 2020 12:50
@gurevichmark gurevichmark self-assigned this Jun 3, 2020
@gurevichmark gurevichmark added this to the 2.16.3 milestone Jul 1, 2021
@besawn besawn modified the milestones: 2.16.3, 2.16.4 Nov 3, 2021
@gurevichmark gurevichmark modified the milestones: 2.16.4, 2.16.5 Jun 14, 2022
@gurevichmark gurevichmark modified the milestones: 2.16.5, 2.16.6 Mar 3, 2023
@Obihoernchen Obihoernchen modified the milestones: 2.16.6, 2.17 Jan 29, 2024
@samveen
Copy link
Member

samveen commented Jan 30, 2024

The potential break comes in the differing expectations:

  • The user expects that the assigned IP is statically assigned to the node, as the node has the value set in hosts.ip .
  • The cluster expects that the node IP should not be in the dynamic range.

I prefer that the node configuration should override the cluster expectation, as it is viewable and thus expected configuration.

Without such a static lease, in the case of a node reboot/restart, the node may not get the same IP, which is potentially disastrous from the cluster's perspective.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Obihoernchen Obihoernchen removed this from the 2.17 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants