Skip to content

Commit

Permalink
address Joseph's remarks
Browse files Browse the repository at this point in the history
  • Loading branch information
xcaruso committed Jun 20, 2023
1 parent fbc175b commit d0a0ea3
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions src/sage/rings/function_field/drinfeld_modules/morphism.py
Original file line number Diff line number Diff line change
Expand Up @@ -454,8 +454,7 @@ def __add__(self, other):
Defn: (z + 1)*t^3 + t^2 + z
"""
u = self.ore_polynomial() + other.ore_polynomial()
return self.parent()(u)
return self.parent()(self.ore_polynomial() + other.ore_polynomial())

def _composition_(self, other, H):
r"""
Expand Down Expand Up @@ -559,7 +558,8 @@ def _motive_matrix(self):
T = KT.gen()
for i in range(1, r):
row = [c.map_coefficients(Frob) for c in row]
row = [(inv*T - B[0]) * row[-1]] + [row[j-1] - B[j]*row[-1] for j in range(1, r)]
row = [(inv*T - B[0]) * row[-1]] \
+ [row[j-1] - B[j]*row[-1] for j in range(1, r)]
rows.append(row)

return matrix(KT, rows)
Expand Down Expand Up @@ -625,8 +625,7 @@ def norm(self, ideal=True):
nu = A([c.in_base() for c in nu.monic().list()])
return A.ideal(nu)
elif self.domain() is self.codomain():
nu = A([c.in_base() for c in nu.list()])
return nu
return A([c.in_base() for c in nu.list()])
else:
raise ValueError("norm is defined as an actual element only for endomorphisms")

Expand Down

0 comments on commit d0a0ea3

Please sign in to comment.