Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

PB-401 Add console renderer #280

Merged
merged 5 commits into from
Feb 11, 2020

Conversation

Robert-Steiner
Copy link
Contributor

@Robert-Steiner Robert-Steiner commented Feb 10, 2020

References

PB-401

Summary

  • enable console renderer in xain fl

Screenshot 2020-02-10 at 16 18 39

Are there any open tasks/blockers for the ticket?

No

Reviewer checklist

Reviewer agreement:

  • Reviewers assign themselves at the start of the review.
  • Reviewers do not commit or merge the merge request.
  • Reviewers have to check and mark items in the checklist.

Merge request checklist

  • Conforms to the merge request title naming XP-XXX <a description in imperative form>.
  • Each commit conforms to the naming convention XP-XXX <a description in imperative form>.
  • Linked the ticket in the merge request title or the references section.
  • Added an informative merge request summary.

Code checklist

  • Conforms to the branch naming XP-XXX-<a_small_stub>.
  • Passed scope checks.
  • Added or updated tests if needed.
  • Added or updated code documentation if needed.
  • Conforms to Google docstring style.
  • Conforms to XAIN structlog style.

@Robert-Steiner Robert-Steiner force-pushed the feature/PB-401-enable-console-renderer branch from f04e274 to 981e235 Compare February 10, 2020 14:14
@Robert-Steiner Robert-Steiner marked this pull request as ready for review February 10, 2020 14:16
@Robert-Steiner Robert-Steiner force-pushed the feature/PB-401-enable-console-renderer branch 2 times, most recently from 31b8e8d to 81b60a8 Compare February 10, 2020 17:11
@Robert-Steiner Robert-Steiner force-pushed the feature/PB-401-enable-console-renderer branch from 81b60a8 to c7dbb75 Compare February 11, 2020 08:50
cache_logger_on_first_use=True,
)

def add_pid_thread(_, __, event_dict) -> dict:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh very nice!

Copy link
Contributor

@little-dude little-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Tis will make debugging easier for sure.

I just have one concern/questionabout losing some logs when loading the configuration.

xain_fl/__main__.py Show resolved Hide resolved
xain_fl/config/schema.py Show resolved Hide resolved
@little-dude little-dude self-requested a review February 11, 2020 10:21
@Robert-Steiner Robert-Steiner merged commit d7ee9d9 into development Feb 11, 2020
@Robert-Steiner Robert-Steiner deleted the feature/PB-401-enable-console-renderer branch February 11, 2020 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants