Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

XP-544 fix aggregate module #235

Merged
merged 4 commits into from
Jan 24, 2020
Merged

Conversation

janpetschexain
Copy link
Contributor

@janpetschexain janpetschexain commented Jan 24, 2020

References

Summary

  • handle division by zero in WeightedAverageAggregator
  • switch to new nomenclature according to the glossary and removed outdated types
  • split weight_update argument into its proper arguments model_weights and aggregation_data

Are there any open tasks/blockers for the ticket?

Follow up:

  • XP-547 write tests for aggregate.py

Reviewer checklist

Reviewer agreement:

  • Reviewers assign themselves at the start of the review.
  • Reviewers do not commit or merge the merge request.
  • Reviewers have to check and mark items in the checklist.

Merge request checklist

  • Conforms to the merge request title naming XP-XXX <a description in imperative form>.
  • Each commit conforms to the naming convention XP-XXX <a description in imperative form>.
  • Linked the ticket in the merge request title or the references section.
  • Added an informative merge request summary.

Code checklist

  • Conforms to the branch naming XP-XXX-<a_small_stub>.
  • Passed scope checks.
  • Added or updated tests if needed.
  • Added or updated code documentation if needed.
  • Conforms to Google docstring style.
  • Conforms to XAIN structlog style.

@janpetschexain janpetschexain changed the title Xp 544 fix aggregate module XP-544 fix aggregate module Jan 24, 2020
@janpetschexain janpetschexain merged commit f440ac5 into development Jan 24, 2020
@janpetschexain janpetschexain deleted the XP-544-fix_aggregate_module branch January 24, 2020 13:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants