Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

DO-58: cache xain-fl dependencies in Docker #232

Merged

Conversation

little-dude
Copy link
Contributor

@little-dude little-dude commented Jan 23, 2020

References

https://xainag.atlassian.net/browse/DO-58

Summary

Some dependencies require a very long compilation: protobuf, numpy,
grpcio. To avoid having to re-install these packages every time, we
pre-install them so that they are cached.

However, we cannot just pre-install a few packages, because we don't
know exactly which version pip will pick for them. Instead, we
give pip all the package's dependencies, and let it resolve and
install them.


Reviewer checklist

Reviewer agreement:

  • Reviewers assign themselves at the start of the review.
  • Reviewers do not commit or merge the merge request.
  • Reviewers have to check and mark items in the checklist.

Merge request checklist

  • Conforms to the merge request title naming XP-XXX <a description in imperative form>.
  • Each commit conforms to the naming convention XP-XXX <a description in imperative form>.
  • Linked the ticket in the merge request title or the references section.
  • Added an informative merge request summary.

Code checklist

  • Conforms to the branch naming XP-XXX-<a_small_stub>.
  • Passed scope checks.
  • Added or updated tests if needed.
  • Added or updated code documentation if needed.
  • Conforms to Google docstring style.
  • Conforms to XAIN structlog style.

Reference: https://xainag.atlassian.net/browse/DO-58

Some dependencies require a very long compilation: protobuf, numpy,
grpcio. To avoid having to re-install these packages every time, we
pre-install them so that they are cached.

However, we cannot just pre-install a few packages, because we don't
know exactly which version `pip` will pick for them. Instead, we
give `pip` all the package's dependencies, and let it resolve and
install them.
@rsaffi rsaffi self-requested a review January 23, 2020 08:39
@little-dude little-dude merged commit 9b583e5 into xaynetwork:development Jan 23, 2020
@little-dude little-dude deleted the DO-58-cache-dependencies branch January 23, 2020 09:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants