Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Project renaming XP-225 #165

Merged
merged 7 commits into from
Dec 2, 2019
Merged

Conversation

tanertopal
Copy link
Contributor

No description provided.

@tanertopal tanertopal changed the title Tanertopal/project renameing xp 225 Project renameing XP-225 Dec 2, 2019
@atymoshchuk
Copy link
Contributor

atymoshchuk commented Dec 2, 2019

My comments on code changes:
1 . Do we want to name our custom logger as xain logger?
2. There is xain.helper.logger mentioned here:
https://github.com/xainag/xain/pull/165/files#diff-400589d09e82de3a870ef1899497c47bR19
Please adjust path as well.
3. Please change '.xain' path to .xain-fl (if we would like to keep it consistent to the project name) here https://github.com/xainag/xain/pull/165/files#diff-8974ad2e47b6bcee8fc9ba94b8a4bc33R10 and also in https://github.com/xainag/xain/pull/165/files#diff-00bf007ad78e7766db38978d2ce69482R16 accordingly.
4. Please change pull request name from renameing to renaming.

@tanertopal tanertopal changed the title Project renameing XP-225 Project renaming XP-225 Dec 2, 2019
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
RELEASE_PROCESS.md Outdated Show resolved Hide resolved
@tanertopal
Copy link
Contributor Author

@Robert-Steiner and @atymoshchuk requested changes applied

@atymoshchuk
Copy link
Contributor

  1. Please change path in comment here: https://github.com/xainag/xain/blob/tanertopal/project_renameing-XP-225/xain_fl/datasets/stats/__main__.py#L19
  2. Would be better to be more generic here: https://github.com/xainag/xain/blob/tanertopal/project_renameing-XP-225/xain_fl/logger.py#L1
    For example: This module contains custom logging configuration and Line 8 accordingly.

@atymoshchuk
Copy link
Contributor

Can you please double check Readme file and correct project name as well, thanks.

@tanertopal tanertopal merged commit 481a9af into master Dec 2, 2019
@tanertopal tanertopal deleted the tanertopal/project_renameing-XP-225 branch December 2, 2019 14:28
dkravetz pushed a commit that referenced this pull request Dec 17, 2019
* Rename package (part of XP-225)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants