rebase

tests/store.py

@@ -85,7 +85,7 @@ def __init__(self, mock_s3_resource):
         self.s3 = mock_s3_resource
 
     def assert_read(self, participant_id: str, round: int):
-        """Check that the local weights for participant ``participand_id`` at
+        """Check that the local weights for participant ``participant_id`` at
         round ``round`` were read exactly once.
 
         """
@@ -141,7 +141,7 @@ def assert_wrote(self, participant_id: str, round: int, weights: np.ndarray):
             participant_id: ID of the participant
             round: round to which the weights belong
         """
-        key = f"{round}/{participand_id}"
+        key = f"{round}/{participant_id}"
         writes = self.s3.writes[key]
         assert writes == 1, f"got {writes} writes for {key}, expected 1"
         assert_ndarray_eq(self.s3.fake_store[key], weights)
@@ -155,7 +155,7 @@ def assert_didnt_write(self, participant_id: str, round: int):
             round: round to which the weights belong
 
         """
-        key = f"{round}/{participand_id}"
+        key = f"{round}/{participant_id}"
         assert self.s3.writes[key] == 0
 
 

tests/test_coordinator.py

@@ -351,14 +351,14 @@ def test_correct_round_advertised_to_participants(coordinator):
     assert response.state == State.STANDBY
 
 
-def test_select_outstanding():
+def test_select_outstanding(coordinator):
     """[summary]
 
     .. todo:: Advance docstrings (https://xainag.atlassian.net/browse/XP-425)
     """
 
     # setup: select first 3 of 4 in order per round
-    coordinator = Coordinator(
+    coordinator = coordinator(
         minimum_participants_in_round=3,
         fraction_of_participants=0.75,
         controller=OrderController(),