Skip to content

Commit

Permalink
Revert "[CI] Split the sim tests and the macOS tests. (#21215)" (#21247)
Browse files Browse the repository at this point in the history
This reverts commit e993173.

It breaks CI (tests are still running duplicated, except for the macOS
tests, which aren't running, except on the xcode16 branch, where they're
running and failing).
  • Loading branch information
rolfbjarne committed Sep 17, 2024
1 parent cfcfd42 commit ae4ef0e
Show file tree
Hide file tree
Showing 7 changed files with 89 additions and 169 deletions.
20 changes: 0 additions & 20 deletions tools/devops/automation/run-post-ci-build-macos-tests.yml

This file was deleted.

1 change: 1 addition & 0 deletions tools/devops/automation/run-post-ci-build-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ resources:
trigger:
stages:
- build_packages
- build_macos_tests

extends:
template: templates/pipelines/run-tests-pipeline.yml
Expand Down
19 changes: 0 additions & 19 deletions tools/devops/automation/run-post-pr-build-macos-tests.yml

This file was deleted.

1 change: 1 addition & 0 deletions tools/devops/automation/run-post-pr-build-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ resources:
trigger:
stages:
- build_packages
- build_macos_tests

extends:
template: templates/pipelines/run-tests-pipeline.yml
Expand Down

This file was deleted.

64 changes: 64 additions & 0 deletions tools/devops/automation/templates/pipelines/run-tests-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,68 @@ parameters:
]
}]

- name: macTestsConfigurations
displayName: macOS test configurations to run
type: object
default: [
{
stageName: 'mac_11_m1',
displayName: 'M1 - Mac Big Sur (11)',
macPool: 'VSEng-VSMac-Xamarin-Shared',
useImage: false,
statusContext: 'M1 - Mac Big Sur (11)',
demands: [
"Agent.OS -equals Darwin",
"macOS.Name -equals BigSur",
"macOS.Architecture -equals arm64",
"Agent.HasDevices -equals False",
"Agent.IsPaired -equals False"
]
},
{
stageName: 'mac_12_m1',
displayName: 'M1 - Mac Ventura (12)',
macPool: 'VSEng-VSMac-Xamarin-Shared',
useImage: false,
statusContext: 'M1 - Mac Monterey (12)',
demands: [
"Agent.OS -equals Darwin",
"macOS.Name -equals Monterey",
"macOS.Architecture -equals arm64",
"Agent.HasDevices -equals False",
"Agent.IsPaired -equals False"
]
},
{
stageName: 'mac_13_m1',
displayName: 'M1 - Mac Ventura (13)',
macPool: 'VSEng-VSMac-Xamarin-Shared',
useImage: false,
statusContext: 'M1 - Mac Ventura (13)',
demands: [
"Agent.OS -equals Darwin",
"macOS.Name -equals Ventura",
"macOS.Architecture -equals arm64",
"Agent.HasDevices -equals False",
"Agent.IsPaired -equals False"
]
},
{
stageName: 'mac_14_x64',
displayName: 'X64 - Mac Sonoma (14)',
macPool: 'VSEng-Xamarin-RedmondMacBuildPool-iOS-Untrusted',
useImage: false,
statusContext: 'X64 - Mac Sonoma (14)',
demands: [
"Agent.OS -equals Darwin",
"macOS.Name -equals Sonoma",
"macOS.Architecture -equals x64",
"Agent.HasDevices -equals False",
"Agent.IsPaired -equals False"
]
}]


resources:
repositories:
- repository: self
Expand Down Expand Up @@ -127,9 +189,11 @@ stages:
pool: ${{ parameters.pool }}
runTests: ${{ parameters.runTests }}
runDeviceTests: ${{ parameters.runDeviceTests }}
runOldMacOSTests: ${{ parameters.runOldMacOSTests }}
runWindowsIntegration: ${{ parameters.runWindowsIntegration }}
runSamples: ${{ parameters.runSamples }}
${{ if ne(length(parameters.testConfigurations), 0)}}:
testConfigurations: ${{ parameters.testConfigurations }}
deviceTestsConfigurations: ${{ parameters.deviceTestsConfigurations }}
macTestsConfigurations: ${{ parameters.macTestsConfigurations }}

23 changes: 23 additions & 0 deletions tools/devops/automation/templates/tests-stage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ parameters:
type: boolean
default: false

- name: runOldMacOSTests
type: boolean
default: true

- name: runWindowsIntegration
type: boolean
default: true
Expand Down Expand Up @@ -153,6 +157,9 @@ parameters:
- name: deviceTestsConfigurations
type: object

- name: macTestsConfigurations
type: object

- name: stageDisplayNamePrefix
type: string
default: ''
Expand Down Expand Up @@ -258,6 +265,22 @@ stages:
commit: ${{ parameters.commit }}
postPipeline: true

- ${{ if eq(parameters.runOldMacOSTests, true) }}:
- ${{ each config in parameters.macTestsConfigurations }}:
- template: ./mac/stage.yml
parameters:
isPR: ${{ parameters.isPR }}
repositoryAlias: ${{ parameters.repositoryAlias }}
commit: ${{ parameters.commit }}
stageName: ${{ config.stageName }}
displayName: ' ${{ parameters.stageDisplayNamePrefix }}${{ config.displayName }}'
macPool: ${{ config.macPool }}
useImage: ${{ config.useImage }}
statusContext: ${{ config.statusContext }}
keyringPass: $(pass--lab--mac--builder--keychain)
demands: ${{ config.demands }}
postPipeline: true

- ${{ if eq(parameters.runWindowsIntegration, true) }}:
- template: ./windows/stage.yml
parameters:
Expand Down

8 comments on commit ae4ef0e

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: ae4ef0e1799e9689fb0659b2de00398c91d947e6 [CI build]

Please sign in to comment.