Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hidden attribute to the password show button #496

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

peteryates
Copy link
Member

This was missed when the password field was initially added. It means the show/hide button can be rendered hidden and then shown if/when the JavaScript kicks in. When missing the button is rendered and it doesn't do anything.

Huge thanks to @colinrotherham for helping diagnose 🙌

Fixes #495

This was missed when the password field was initially added. It means
the show/hide button can be rendered hidden and then shown if/when the
JavaScript kicks in. When missing the button is rendered and it doesn't
do anything.
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for govuk-form-builder ready!

Name Link
🔨 Latest commit 3328cd0
🔍 Latest deploy log https://app.netlify.com/sites/govuk-form-builder/deploys/661eaea68d22a400089c1684
😎 Deploy Preview https://deploy-preview-496--govuk-form-builder.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@peteryates peteryates merged commit 02c3663 into main Apr 16, 2024
17 checks passed
@peteryates peteryates deleted the add-hidden-attribute-to-password-show-button branch April 16, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show/hide password button should be optional
1 participant