GOV.UK Frontend 4.4.0 #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following three suggestions from the release notes[0] are implemented in this commit. * Remove aria-labelledby="error-summary-title" and role="alert" from the parent element (govuk-error-summary) * Add a div wrapper around the contents of govuk-error-summary with the attribute role="alert" * Remove id="error-summary-title" from the error summary h2 (govuk-error-summary__title) [0] https://github.com/alphagov/govuk-frontend/releases/tag/v4.4.0
👷 Deploy Preview for govuk-form-builder processing.
|
peteryates
commented
Nov 14, 2022
Comment on lines
+21
to
+23
| tag.div(role: "alert") do | ||
| safe_join([title, summary]) | ||
| end |
There was a problem hiding this comment.
- Add a div wrapper around the contents of
govuk-error-summarywith the attributerole="alert"
peteryates
commented
Nov 14, 2022
| @@ -20,19 +20,18 @@ | |||
| specify 'the error summary should have a title' do | |||
| expect(subject).to have_tag( | |||
| 'h2', | |||
| with: { id: 'error-summary-title', class: 'govuk-error-summary__title' } | |||
| with: { class: 'govuk-error-summary__title' } | |||
There was a problem hiding this comment.
- Remove
id="error-summary-title"from the error summary h2 (govuk-error-summary__title)
peteryates
commented
Nov 14, 2022
Comment on lines
-124
to
-130
| role: 'alert', | ||
| data: { | ||
| module: %(#{brand}-error-summary) | ||
| }, | ||
| aria: { | ||
| labelledby: [summary_title_id.presence] | ||
| } |
There was a problem hiding this comment.
- Remove
aria-labelledby="error-summary-title"androle="alert"from the parent element (govuk-error-summary)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOV.UK Frontend was released earlier today.
It looks like the vast majority of the changes are in the JavaScript and don't apply to this gem.
The ones that do are in the error summary; the following suggestions have been implemented 7ee5ce1.