Remove incorrect quote and reword the single checkbox instructions #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The quote in the 'small checkboxes' section should really have been in the 'generating a single checkbox' one. Also tried to improve the phrasing of the single checkbox documentation a little. Fixes #243
ethanmills
reviewed
Feb 19, 2021
Now there's reassurance at the top that the hidden fields required for empty submissions are added by default. There's also a yellow 'important' box in the single checkbox section that explains why `multiple: false` is needed for both the fieldset and the checkbox.
It doesn't really look all that good 😞
|
Relevant page in the review app here: https://deploy-preview-244--govuk-form-builder.netlify.app/form-elements/checkboxes/ |
peteryates
force-pushed
the
remove-incorrect-section-from-checkbox-docs-and-reword
branch
from
c682df5
to
69be4e5
Compare
peteryates
deleted the
remove-incorrect-section-from-checkbox-docs-and-reword
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quote in the 'small checkboxes' section should really have been in the 'generating a single checkbox' one. Also tried to improve the phrasing of the single checkbox documentation a little.Ended up rewording most of the guidance on the checkboxes page. It definitely feels like it makes more sense now.
Fixes #243