Upgrade to GOV.UK Frontend version 3.11.0 #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 3.11.0 of the GOV.UK Frontend introduced button groups[0]. The grouping makes it easier to lay out buttons and links side-by-side than previously, which required a margin to be added to the right of each button that had another after it. The ButtonGroup class is currently bare but it _may_ be useful if we extend it to allow extra classes or attributes to be set on the group. [0] https://github.com/alphagov/govuk-frontend/releases/tag/v3.11.0
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest revision to the design system brings one change that affects this library, button groups.
Previously the behaviour was to automatically apply a right margin to the submit input when additional content was passed into
govuk_submitvia a block.The new behaviour is to wrap the submit input and the block contents in a
div.govuk-button-group; this will allow the buttons and links within to be nicely arranged.