Add Ruby 3.0.0 to supported versions #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 2.5.8 has been dropped from the officially-supported versions list and will no longer make up part of the testing matrix, but it will probably continue to work and be unofficially supported.
Rails 5.2.4 doesn't work with Ruby 3.0.0. Rails 5.2.0 was released nearly three years ago and most projects using this library are on later versions. This is only dropping *official* support, it's likely that the gem will continue to work for the time being but Rails 5.2.4 will no longer be tested as part of the build.
peteryates
force-pushed
the
ruby-3.0.0
branch
from
c0c4315
to
d436f82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrade drops support for:
The gem will probably run just fine on them for the foreseeable future but they will no longer for part of the testing matrix and won't be officially supported.
There are two things holding this back:Rubocop
It appears that
govuk-rubocophasn't caught up yet.We'll wait for this for a time but can switch to vanilla Rubocop if it becomes a blocker.
Rails 5.2.4
It appears that Rails 5.2.4 isn't compatible with Ruby 3.0.0. This is probably due to the separation of positional and keyword arguments due to seeing this a lot in the build log:
It may be the case that it's also dropped to unofficially supported status.
Feedback welcome.