Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Formula] Make word wrap button show its state #35

Conversation

dej611
Copy link

@dej611 dej611 commented Jun 4, 2021

Summary

Manage the word wrap state by the react component.

The UI problem was due to the state of isWordWrapped managed internally by monaco and not triggering a component rerender.
The editor is now following the component directives on this side.

lens_formula_word_wrap

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@dej611 dej611 mentioned this pull request Jun 4, 2021
69 tasks
@wylieconlon wylieconlon merged commit bbfd225 into wylieconlon:lens/formula-error-handling Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants