Allow developers to enable auto-login for their frontend #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
pklaschka
added
📕 documentation
Graphite App
Base automatically changed from
01-12-Restore_login_session_upon_reload
to
main
January 17, 2024 16:53
With this change, the `setAutoLoginCredentials()` function gets exposed as a public API. While it should be used with extreme care (since using it means hard-coding the NATS credentials into the built frontends), this enables developers to enable auto-login in their Telestion based frontends by calling:
```tsx
setAutoLoginCredentials({
natsUrl: 'ws://localhost:9222',
username: 'nats',
password: 'nats'
});
```
While there are, obviously, security risks associated with this, some use-cases require such functionality which is why it gets exposed as an official API to at least make it as secure as possible by tightly integrating it into the core framework. To make developers aware of the security implications, they are described in the documentation and the function is marked as `@deprecated` for extra attention.
pklaschka
force-pushed
the
01-12-Allow_developers_to_enable_auto-login_for_their_frontend
branch
from
2e14961
to
dce62c6
Compare
pklaschka
deleted the
01-12-Allow_developers_to_enable_auto-login_for_their_frontend
branch
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the
setAutoLoginCredentials()function gets exposed as a public API. While it should be used with extreme care (since using it means hard-coding the NATS credentials into the built frontends), this enables developers to enable auto-login in their Telestion based frontends by calling:While there are, obviously, security risks associated with this, some use-cases require such functionality which is why it gets exposed as an official API to at least make it as secure as possible by tightly integrating it into the core framework. To make developers aware of the security implications, they are described in the documentation and the function is marked as
@deprecatedfor extra attention.