Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some minor issues #6

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Fix some minor issues #6

merged 2 commits into from
Sep 23, 2024

Conversation

kjsanger
Copy link
Member

@kjsanger kjsanger commented Sep 23, 2024 •
edited
Loading

("showing" -> "shadowing" in commit message)

@kjsanger
Fix return value of create_task
337733b 
create_task is a void function.
@kjsanger
Fix id parameter showing builtin "id"
6b983eb 
Fix docstrings with single rather than triple quotes.
nerdstrike
nerdstrike approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@nerdstrike nerdstrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. I remain unpersuaded that adding """ to single-line strings constitutes an improvement, but that's black for you.

@kjsanger
Copy link
Member Author

It's not black - it's just Python https://peps.python.org/pep-0257/

@kjsanger kjsanger merged commit 4e45baa into wtsi-npg:devel Sep 23, 2024
1 check passed
@kjsanger kjsanger deleted the fix/misc branch September 23, 2024 12:44
@kjsanger kjsanger mentioned this pull request Sep 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdstrike nerdstrike nerdstrike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjsanger @nerdstrike