Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unclosed quote #350

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Fix unclosed quote #350

merged 1 commit into from
Feb 2, 2023

Conversation

cliffordp
Copy link
Contributor

Not sure if it requires being surrounded by quotes so PR might need an adjustment in the other direction

Not sure if it requires being surrounded by quotes so PR might need an adjustment in the other direction
@cliffordp cliffordp requested a review from a team as a code owner February 2, 2023 23:10
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine without the quote. Thanks @cliffordp !

@danielbachhuber danielbachhuber added this to the 2.4.1 milestone Feb 2, 2023
@danielbachhuber danielbachhuber modified the milestones: 2.4.1, 2.4.2 Feb 2, 2023
@danielbachhuber danielbachhuber merged commit 5ff22bf into wp-cli:main Feb 2, 2023
@swissspidy
Copy link
Member

swissspidy commented Feb 2, 2023

@danielbachhuber @cliffordp the readme is generated from the source code, so it needs to be fixed there instead. otherwise the change gets overriddem with the next sync

@danielbachhuber
Copy link
Member

@swissspidy Oops, I thought this was a change to the command. I've updated the command with 9d09e90

Thanks for the catch!

@cliffordp cliffordp deleted the patch-1 branch February 3, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants