Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve warnings for strings with different comments #318

Merged
merged 6 commits into from
Jul 4, 2022
Merged

Improve warnings for strings with different comments #318

merged 6 commits into from
Jul 4, 2022

Conversation

swissspidy
Copy link
Member

@swissspidy swissspidy commented May 2, 2022 •
edited
Loading

Lists all different comments attached to the string after the warning.

Example output:

$ wp i18n make-pot foo-plugin
Plugin file detected.
Warning: The string "Hello World" has 2 different translator comments. (foo-plugin.php:7)
translators: Translators 1!
Translators: Translators 2!
Success: POT file successfully generated!

Fixes #227

@swissspidy swissspidy added this to the 2.4.0 milestone May 2, 2022
@swissspidy swissspidy requested a review from a team as a code owner May 2, 2022 12:32
@swissspidy swissspidy mentioned this pull request May 2, 2022
Closed
@swissspidy
Copy link
Member Author

Related: #119

@schlessera schlessera merged commit 0204ade into main Jul 4, 2022
@schlessera schlessera deleted the fix/227-references branch July 4, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera schlessera approved these changes

Assignees
No one assigned
Labels
command:i18n-make-pot
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Translators comment audit - tell me in which files the different comment is
2 participants
@swissspidy @schlessera