Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --debug output for the file being processed. #183

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Add --debug output for the file being processed. #183

merged 2 commits into from
Oct 22, 2019

Conversation

ocean90
Copy link
Contributor

@ocean90 ocean90 commented Oct 18, 2019

For debugging purposes it would be helpful to know what file is currently processed.

Initially suggested by @schlessera.

@ocean90 ocean90 requested a review from a team as a code owner October 18, 2019 20:12
@ocean90 ocean90 mentioned this pull request Oct 18, 2019
Closed
schlessera
schlessera requested changes Oct 21, 2019
View reviewed changes
src/JsCodeExtractor.php Outdated Show resolved Hide resolved
@schlessera
Copy link
Member

@ocean90 Using sprintf() and multiple lines here is overkill and detracts from the actual logic. I'd prefer each of these to be single lines instead.

@schlessera schlessera added this to the 2.2.1 milestone Oct 22, 2019
@schlessera
Copy link
Member

All failures unrelated (and waiting for php-gettext/Gettext#231 to get solved), so merging as-is.

@schlessera schlessera merged commit 96e74a5 into wp-cli:master Oct 22, 2019
@ocean90 ocean90 deleted the feature/debug-message-file-parsing branch October 22, 2019 16:56
@kkmuffme kkmuffme mentioned this pull request Nov 15, 2019
Closed
@ocean90 ocean90 mentioned this pull request May 5, 2020
Closed
schlessera added a commit that referenced this pull request Jan 6, 2022
@schlessera
Add --debug output for the file being processed. (#183)
5b8c86a 
Add `--debug` output for the file being processed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera schlessera approved these changes

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
command:i18n-make-pot
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ocean90 @schlessera @swissspidy