Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Bzlmod. #33

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Migrate to Bzlmod. #33

merged 1 commit into from
Jan 24, 2024

Conversation

SanjayVas
Copy link
Member

This updates Bazel to 6.4.0.

@wfa-reviewable
Copy link

This change is Reviewable

Copy link

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 7 files at r1, all commit messages.
Reviewable status: 4 of 7 files reviewed, 2 unresolved discussions (waiting on @SanjayVas)


.bazelrc line 4 at r1 (raw file):

common --enable_bzlmod
# TODO(@SanjayVas): Update this when the repo has been moved to the WFA org.
common --registry=https://github.com/SanjayVas/bazel-registry/main/

what is this for?


build/non_module_deps.bzl line 26 at r1 (raw file):

        urls = [
            # 2023-07-30
            "https://github.com/google/private-join-and-compute/archive/f77f26fab7f37e5e1e2d43250662c0281bd7fa4a.tar.gz",

shouldn't this be coming from common-cpp?

Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 7 files reviewed, 2 unresolved discussions (waiting on @stevenwarejones)


.bazelrc line 4 at r1 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

what is this for?

This is to include the Bazel registry for our modules in addition to the Bazel Central Registry (BCR).

Sorry, I hadn't meant to send this out for review yet as it's not a leaf repo and therefore currently depends on repos under my GitHub user. I'll send out PRs later for setting up the modules and Bazel registry in the WFA org.


build/non_module_deps.bzl line 26 at r1 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

shouldn't this be coming from common-cpp?

No.

  1. Bzlmod uses strict dependency visibility, you have to indicate all direct dependencies even if they are also included transitively.
  2. common-cpp doesn't actually use this, so it does not have this dependency post-migration. See Migrate to Bzlmod. common-cpp#40

Copy link

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 4 of 7 files reviewed, 2 unresolved discussions

@SanjayVas SanjayVas marked this pull request as ready for review December 19, 2023 18:00
Copy link

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 7 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)

Copy link

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

Copy link

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas
Copy link
Member Author

I'm going to wait for pending PR #39 to be merged to avoid disruption.

This updates Bazel to 6.4.0.
@SanjayVas SanjayVas enabled auto-merge (squash) January 24, 2024 19:13
@SanjayVas SanjayVas merged commit 89d7e73 into main Jan 24, 2024
3 checks passed
@SanjayVas SanjayVas deleted the sanjayvas-bzlmod branch January 24, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants