Changes for gb mobile upgrade to rn 0.61 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… true. requestAudioFocus was being run regardless of there being a src, so I made it so that only gets requested when a src exists.
Adds onPlaybackRateChange info to README
…collision-3 Replace RCTBubblingEventBlock by RCTDirectEventBlock to avoid event name collision with Expo AV
Remove video player when entering background correctly
Make installation parts easier to link
fix typo
Make more obvious the changes needed via using diff
fix indent
Update androidx
…elease/5.0.0 Release/5.0.0
(cherry picked from commit a96fa33)
(cherry picked from commit 3ddcba3)
(cherry picked from commit 976ebcc)
(cherry picked from commit ed25b3f)
(cherry picked from commit 8a8f215)
(cherry picked from commit b0737bd)
(cherry picked from commit 2f23cc0)
…rry-pick [FIX] Fix release 5.0.0 bad merge with 5.0.1
…_x_migration-upstream5.0.1
…le-upgrade-to-rn-0.61
1 task
SergioEstevao
deleted the
try/changes-for-gb-mobile-upgrade-to-rn-0.61
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redoing of the #3 PR.
Part of the upgrade to RN 0.61 PR domino, don't merge until all PRs are green and ready to merge.
Unfortunately, gutenberg-mobile started pointing to
try/fix-video-overflow-issue-in-gb-mobile-take-3while #3 got merged toexperiment/android_x_migration. The latter was used as an adhoc canonical branch to merge things to use in gb-mobile, but as said, gb-mobile points to the...take3branch now. It's messy, yeah.To try and clean up things, I've branched off
...take3introducing the fork-for-gutenberg-mobile branch as an attempt to have a better named "canonical" branch for gb-mobile.This PR just tries to bring the #3 work into the newly created branch. #3 should now be defunct, since I'm also going to reset
experiment/android_x_migrationback to 6c75579, the last hash used in gb-mobile.