Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds install-node-dependencies command to Build JS Bundles #6736

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Mar 14, 2024

Fixes #

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added the Tooling label Mar 14, 2024
@@ -128,8 +128,7 @@ steps:
echo "--- :node: Set up Node environment"
nvm install && nvm use

echo "--- :npm: Install Node dependencies"
npm ci --unsafe-perm --prefer-offline --no-audit --no-progress
.buildkite/commands/install-node-dependencies.sh
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mokagio 👋 I saw we weren't using the newly introduced install-node-dependencies.sh for the JS Bundle generation. Is it because we are using a docker container? I tried to add it but it failed 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant