Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Dismiss on PlainText in Android #1871

Merged
merged 2 commits into from
Feb 7, 2020
Merged

Enable Dismiss on PlainText in Android #1871

merged 2 commits into from
Feb 7, 2020

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Feb 7, 2020 •
edited
Loading

Fixes #1864

Related PRs:
gutenberg-pr: WordPress/gutenberg#20095

To test:

Blocks with PlainText:

  • code
  • shortcode

Existing Field

  1. Open a page or post with a block that uses the PlainText component.
  2. Click on the field
  3. Edit or leave unchanged
  4. Click the keyboard dismiss button
    Expect the keyboard to dismiss

New Field

  1. Select to add a new component with the PlainText component
    Expect the keyboard to dismiss
  2. Add text or leave blank
  3. Click the keyboard dismiss button
    Expect the keyboard to dismiss

Screen Recording 2020-02-07 at 8 53 25 AM 2020-02-07 08_58_12

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder chipsnyder mentioned this pull request Feb 7, 2020
Merged
6 tasks
@chipsnyder chipsnyder changed the base branch from develop to release/1.22.0 February 7, 2020 14:24
marecar3
marecar3 approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work @chipsnyder!

@marecar3
Copy link
Contributor

marecar3 commented Feb 7, 2020 •
edited
Loading

Don't forget to update the reference 😄 ( after merging )

@chipsnyder chipsnyder merged commit 4ef6a4b into release/1.22.0 Feb 7, 2020
@chipsnyder chipsnyder deleted the issue/1864-shortcode-keyboard branch February 7, 2020 19:09
This was referenced Feb 7, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marecar3 marecar3 marecar3 approved these changes

@hypest hypest Awaiting requested review from hypest

Assignees
No one assigned
Labels
bugfix [OS] Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android] Keyboard dismiss button doesn't dismiss the keyboard in the Shortcode block
2 participants
@chipsnyder @marecar3