Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Gutenberg-Mobile to Android 13 #5556

Closed
13 tasks done
ravishanker opened this issue Mar 14, 2023 · 11 comments · Fixed by wordpress-mobile/WordPress-Android#18477
Closed
13 tasks done

Upgrade Gutenberg-Mobile to Android 13 #5556

ravishanker opened this issue Mar 14, 2023 · 11 comments · Fixed by wordpress-mobile/WordPress-Android#18477
Assignees
@fluiddot
Labels
Android 13 [OS] Android [Type] Task

Comments

@ravishanker
Copy link

ravishanker commented Mar 14, 2023 •
edited by fluiddot
Loading

The library will be upgraded to Android 13.

Tasks

  • Upgrade compileSdk to 33
  • Upgrade targetSdk to 33
  • Bump the Aztec Editor version on Gutenberg in #5556
  • Bump the Aztec Editor version on WPAndroid
  • Upgrade compileSdk and targetSdk to 33 in react-native-libraries-publisher
  • Upgrade compileSdk and targetSdk to 33 in react-native-gesture-handler
  • Upgrade compileSdk and targetSdk to 33 in react-native-linear-gradient
  • Upgrade compileSdk and targetSdk to 33 in react-native-prompt-android
  • Upgrade compileSdk and targetSdk to 33 in react-native-reanimated
  • Upgrade compileSdk and targetSdk to 33 in react-native-slider
  • Upgrade compileSdk and targetSdk to 33 in react-native-video
  • Publish a new version
  • Update WPAndroid
@ravishanker ravishanker self-assigned this Mar 14, 2023
@fluiddot
Copy link
Contributor

Hey @ravishanker 👋, I see you self-assigned to this task, if you are planning to tackle this let me share the references that we'd need to update for the Android 13 upgrade. We have three libraries in the Gutenberg repository that need to be updated:

1 - react-native-editor

This is the main library that is invoked in the main apps to initialize the editor. However, part of the native code is related to a demo project that we use for testing the editor.

NOTE: Apart from updating compileSdkVersion and targetSdkVersion, it would be great to check other settings that we might also need to update for Android 13.

2- react-native-bridge

This library is where we hold the logic of the bridge between React Native and the main apps.

NOTE: Similar to the above note, it would be great to check other settings, especially the WordPress-Utils-Android dependency.

3 - react-native-aztec

This is a wrapper library to include Aztec in the editor. If we plan to also upgrade Android 13 in Aztec-Android, we'd also need to bump the version here.

NOTE: Similar to the above note, it would be great to check other settings, especially the WordPress-Utils-Android dependency.

@ravishanker
Copy link
Author

👋 @fluiddot - Thank you for the note and instructions.

I've tried in vain to do this upgrade. Looks like I need to for a few repositories and do a a lot of setup. Still won't be sure, it's done properly.

Would it be easier for you or someone on your team to do it quickly and easily? 🙇

@ravishanker ravishanker assigned fluiddot and unassigned ravishanker Mar 16, 2023
@ravishanker
Copy link
Author

Probably better to do both compileSdkVersion and targetSdkVersion at once and publish a new release that can be updated in WP repo. Wdyt?

@ravishanker
Copy link
Author

How does this PR relate to this work wordpress-mobile/AztecEditor-Android#1037

@ravishanker ravishanker mentioned this issue Mar 16, 2023
Closed
@fluiddot
Copy link
Contributor

Hey @ravishanker 👋 ,

Would it be easier for you or someone on your team to do it quickly and easily? 🙇

Yeah, it's likely that someone from the GB-mobile team could take over this. Although I'm not sure about the bandwidth for this with the ongoing projects. cc @twstokes

Probably better to do both compileSdkVersion and targetSdkVersion at once and publish a new release that can be updated in WP repo. Wdyt?

Ok, I agree. Once we do the Android 13 upgrade in Gutenberg Mobile, we'd need to do an alpha release to incorporate the changes into the WordPress/Jetpack app.

Based on all the dependencies we need to update related to GB-mobile, I think the process should be:

  1. Upgrade Android 13 in WordPress-Utils-Android (Upgrade WordPress-Utils-Android to Android 13 WordPress-Utils-Android#123).
  2. Bump the WordPress-Utils-Android version in AztecEditor-Android (reference).
  3. Upgrade Android 13 in AztecEditor-Android (Update compile sdk to 33 AztecEditor-Android#1037).
  4. Create a new AztecEditor-Android version.
  5. Upgrade Android 13 in Gutenberg Mobile.
  6. Bump the AztecEditor-Android version in Gutenberg Mobile.
  7. Bump the WordPress-Utils-Android version in Gutenberg Mobile.
  8. Create a new Gutenberg Mobile release and incorporate it in WordPress-Android.
  9. Bump the AztecEditor-Android version in WordPress-Android.
  10. Bump the WordPress-Utils-Android version in WordPress-Android.

@ravishanker let me know if the above steps looks good, thanks!

How does this PR relate to this work wordpress-mobile/AztecEditor-Android#1037

Yes, it's definitely related, check the above steps.

@irfano
Copy link
Member

irfano commented Mar 16, 2023

  1. Upgrade Android 13 in WordPress-Utils-Android (Upgrade WordPress-Utils-Android to Android 13 WordPress-Utils-Android#123).
  2. Bump the WordPress-Utils-Android version in AztecEditor-Android (reference).
  3. Upgrade Android 13 in AztecEditor-Android (Update compile sdk to 33 AztecEditor-Android#1037).
  4. Create a new AztecEditor-Android version.
  5. Upgrade Android 13 in Gutenberg Mobile.
  6. Bump the AztecEditor-Android version in Gutenberg Mobile.
  7. Bump the WordPress-Utils-Android version in Gutenberg Mobile.
  8. Create a new Gutenberg Mobile release and incorporate it in WordPress-Android.
  9. Bump the AztecEditor-Android version in WordPress-Android.
  10. Bump the WordPress-Utils-Android version in WordPress-Android.

@fluiddot, should we update all these libraries and bump their versions in consumer projects simultaneously? For instance, can we do item 6 in a release of Gutenberg and item 7 in the next release?
Doing that seems fine to me.

@fluiddot
Copy link
Contributor

@fluiddot, should we update all these libraries and bump their versions in consumer projects simultaneously? For instance, can we do item 6 in a release of Gutenberg and item 7 in the next release?

Good question. I think the only library that we'd need to bump simultaneously is Aztec because it's used on both projects WP-Android (specifically for the Classic editor) and Gutenberg Mobile.

I checked the use of WordPress-Utils-Android library in Gutenberg Mobile (reference), and we only use the AppLog so most likely we won't have any incompatibility due to pointing to an older version.

Being this said, the main blocker I see right now is executing in the same release the points:

  • 5 - Upgrade Android 13 in Gutenberg Mobile.
  • 6 - Bump the AztecEditor-Android version in Gutenberg Mobile.
  • 9 - Bump the AztecEditor-Android version in WordPress-Android.

Doing that seems fine to me.

👍

@ravishanker ravishanker mentioned this issue Mar 24, 2023
Merged
12 tasks
@irfano
Copy link
Member

irfano commented Mar 30, 2023

👋🏻 @fluiddot!

  1. Upgrade Android 13 in WordPress-Utils-Android (Upgrade WordPress-Utils-Android to Android 13 WordPress-Utils-Android#123).
  2. Bump the WordPress-Utils-Android version in AztecEditor-Android (reference).
  3. Upgrade Android 13 in AztecEditor-Android (Update compile sdk to 33 AztecEditor-Android#1037).
  4. Create a new AztecEditor-Android version.
  5. Upgrade Android 13 in Gutenberg Mobile.

Items before "5. Upgrade Android 13 in Gutenberg Mobile." are done. Can we start this issue now?

Yeah, it's likely that someone from the GB-mobile team could take over this. Although I'm not sure about the bandwidth for this with the ongoing projects.

Can you help us assign someone to the issue from GB-mobile team? What is the availability of the team? cc: @twstokes

@twstokes
Copy link
Contributor

twstokes commented Apr 4, 2023

👋 Hey @irfano - we can prioritize this work after the completion of the VideoPress block project, which should wrap up around April 14th.

@twstokes twstokes mentioned this issue Apr 26, 2023
Closed
9 tasks
@twstokes
Copy link
Contributor

twstokes commented May 2, 2023

Update from my side on timing: We're now aiming for May 15th due to other projects that took priority.

Ref: p1683047487883239/1683046494.190819-slack-C04T5JXRR16

@fluiddot
Copy link
Contributor

Heads up that I'm going to add new tasks related to updating React Native library dependencies:

  • Upgrade compileSdk and targetSdk to 33 in react-native-libraries-publisher
  • Upgrade compileSdk and targetSdk to 33 in react-native-gesture-handler
  • Upgrade compileSdk and targetSdk to 33 in react-native-linear-gradient
  • Upgrade compileSdk and targetSdk to 33 in react-native-prompt-android
  • Upgrade compileSdk and targetSdk to 33 in react-native-reanimated
  • Upgrade compileSdk and targetSdk to 33 in react-native-slider
  • Upgrade compileSdk and targetSdk to 33 in react-native-video

This was referenced May 18, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
@jhnstn jhnstn mentioned this issue Jun 9, 2023
Merged
4 tasks
@notandyvee notandyvee mentioned this issue Jan 10, 2024
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fluiddot fluiddot

Labels
Android 13 [OS] Android [Type] Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Gutenberg] Upgrade Android 13 wordpress-mobile/WordPress-Android
5 participants
@ravishanker @twstokes @irfano @fluiddot @jostnes