Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Upgrade React Native 0.71.11 #20956

Merged
merged 57 commits into from
Jul 27, 2023

Commits on Jul 3, 2023

  1. Configuration menu
    Copy the full SHA
    b7fd735 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    27e6b3f View commit details
    Browse the repository at this point in the history
  3. Use latest CocoaPods version

    No other than reason than me looking at the CocoaPods setup and
    realizing we were a few versions behind.
    mokagio committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    22334c5 View commit details
    Browse the repository at this point in the history
  4. Switch to tar.gz for the Gutenberg XCFramework archive

    Despite it working during the prototype stage, I wasn't able to get the
    XCFrameworks out of the ZIP archive, but it works fine with the tar.gz.
    
    I suspect this has to do with the folder(s) generated when
    decompressing.
    mokagio committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    aca165e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    211b497 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0aa0487 View commit details
    Browse the repository at this point in the history
  7. Add a couple of newly required import React

    These are unnecessary at the moment but will be when we move to
    Gutenberg via XCFramework
    mokagio committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    dffeb71 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1acc425 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8176593 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7d31186 View commit details
    Browse the repository at this point in the history
  11. Remove pre_install download hook in favor of prepare_command

    The advantage of this approach is that downloading the archive is only
    necessary when using a local spec. Defining the logic in the local spec
    itself keeps everything self contained and saves us from having to
    conditionally call the `pre_install` hook.
    mokagio committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    27186a2 View commit details
    Browse the repository at this point in the history
  12. Use remote spec instead of a local one for Gutenberg via commit

    The idea was to use a local spec and interpolated the desired commit
    SHA1 in the `source` to download the corresponding `tar.gz`.
    
    However, CocoaPods has some issues with local specs that use `http`
    `source`, as documented in:
    
    - CocoaPods/CocoaPods#10288 (comment)
    - https://github.com/firebase/firebase-ios-sdk/blob/68b39b8edf61f6e643e2396e712c7c67e0f146ff/scripts/pod_lib_lint.rb#L70-L78
    
    Using a remote spec doesn't have the same issue, and the cost in terms
    of extra computation and storage is negligible when compared to building
    and hosting the `tar.gz` archives.
    mokagio committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    a4c6070 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    11b0d2c View commit details
    Browse the repository at this point in the history
  14. Use Xcode 14.3.1

    This was done to address the following CI failure when building with the
    Gutenberg XCFramework:
    
    ```
    ▸ Linking WordPress
    ⚠️  ld: Could not find or use auto-linked library 'swiftCompatibility56'
    
    ❌  ld: symbol(s) not found for architecture x86_64
    ```
    
    https://buildkite.com/automattic/wordpress-ios/builds/14356#01885545-c05a-43a8-b475-d0d683857672
    mokagio committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    64ac588 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    ede6c5d View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    0806f9b View commit details
    Browse the repository at this point in the history
  17. Do not @testable import Gutenberg in unit tests

    Because the latest XCFramework setup ships without testing compilation.
    mokagio committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    dfae970 View commit details
    Browse the repository at this point in the history
  18. DRY logic setting Gutenberg URL when using tag or commit

    Co-authored-by: Tony Li <tony.li@automattic.com>
    mokagio and crazytonyli committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    4726973 View commit details
    Browse the repository at this point in the history
  19. Simplify gutenberg_dependencies with early return

    Co-authored-by: Tony Li <tony.li@automattic.com>
    mokagio and crazytonyli committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    c2c46cc View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Configuration menu
    Copy the full SHA
    59d7b78 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d03be58 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3fcd1b5 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Configuration menu
    Copy the full SHA
    b6b8d9c View commit details
    Browse the repository at this point in the history
  2. Update Podfile.lock file

    fluiddot committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    d6dd34e View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Configuration menu
    Copy the full SHA
    d81f466 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Configuration menu
    Copy the full SHA
    f875968 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'trunk' into mokagio/gutenberg-xcframework-setup

    # Conflicts:
    #	Podfile.lock
    fluiddot committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    9192af0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    381d49a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ebd4cca View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2b1138f View commit details
    Browse the repository at this point in the history
  6. Merge and fix pre-install logic into gutenberg_dependencies block

    The pre-install logic is only needed when using local Gutenberg installation. Hence, we can merge it into the `gutenberg_dependencies`, which is only used in that case.
    
    Additionally, the React Native modules path has been fixed to point to the local installation.
    
    Fix empty line after guard clause lint issue
    fluiddot committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    65e5454 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2d40a68 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    598b038 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    341f617 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    551968e View commit details
    Browse the repository at this point in the history
  11. Reintroduce link to internal doc with "Do Not Embed" explanation

    Co-authored-by: Olivier Halligon <olivier.halligon@automattic.com>
    mokagio and AliSoftware authored Jul 19, 2023
    Configuration menu
    Copy the full SHA
    723f8ed View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Configuration menu
    Copy the full SHA
    9ceb947 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e39537b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4530832 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #21143 from wordpress-mobile/test/latest-wip-xcfra…

    …mework-and-ui-tests
    
    Fix failing UI tests after React Native upgrade in Gutenberg
    fluiddot authored Jul 20, 2023
    Configuration menu
    Copy the full SHA
    170d7f4 View commit details
    Browse the repository at this point in the history
  5. Update Gutenberg Mobile ref

    fluiddot committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    a4fe6e8 View commit details
    Browse the repository at this point in the history
  6. Update release notes

    fluiddot committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    d7cf5c3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4945d03 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Merge remote-tracking branch 'origin/trunk' into gutenberg/upgrade/re…

    …act-native-0.71.11
    
    I addressed the conflicts in `BlockEditorScreen.swift` by keeping the
    new query syntax from
    #21122 and the
    typing workaround from
    #21143
    mokagio committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    795a9c2 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'mokagio/gutenberg-xcframework-setup' into gutenberg/upg…

    …rade/react-native-0.71.11
    fluiddot committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    64811c6 View commit details
    Browse the repository at this point in the history
  3. Remove adding React-jsc Pod

    fluiddot committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    c992bcb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7e11b1e View commit details
    Browse the repository at this point in the history
  5. Update Gutenberg Mobile ref

    fluiddot committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    6ce7fdc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    59b6bb3 View commit details
    Browse the repository at this point in the history
  7. Merge branch 'trunk' into gutenberg/upgrade/react-native-0.71.11

    # Conflicts:
    #	Gutenberg/version.rb
    #	Podfile.lock
    fluiddot committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    8c8f945 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Merge branch 'trunk' of github.com:wordpress-mobile/WordPress-iOS int…

    …o gutenberg/upgrade/react-native-0.71.11
    dcalhoun committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e39dfaf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    12164fc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4642cfb View commit details
    Browse the repository at this point in the history
  4. Re-introduce SDWebImage pod

    fluiddot committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    131057d View commit details
    Browse the repository at this point in the history
  5. Merge branch 'trunk' into gutenberg/upgrade/react-native-0.71.11

    # Conflicts:
    #	WordPress/WordPress.xcodeproj/project.pbxproj
    fluiddot committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    812b034 View commit details
    Browse the repository at this point in the history
  6. Update release notes

    fluiddot committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    40541ae View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    66ad340 View commit details
    Browse the repository at this point in the history