Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Bump react-native-gesture-handler to version 2.3.2 #18742

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented May 26, 2022

To test:
Observe that drag & drop functionality works as expected.

Regression Notes

  1. Potential unintended areas of impact
    None apart of the editor.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the Gutenberg Editing and display of Gutenberg blocks. label May 26, 2022
@fluiddot fluiddot added this to the 20.0 milestone May 26, 2022
@fluiddot fluiddot requested a review from geriux May 26, 2022 10:31
@fluiddot fluiddot self-assigned this May 26, 2022
@fluiddot fluiddot marked this pull request as ready for review May 26, 2022 10:34
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 26, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18742-4be634f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 26, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18742-4be634f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and it worked correctly 🚀

@fluiddot
Copy link
Contributor Author

I tested using the build pr18742-51fa1bf and confirm that the Drag & Drop functionality works as expected 🎊 .

@fluiddot
Copy link
Contributor Author

Heads up that I'm changing the target branch to gutenberg/after_1.77.0 as the 1.77.0 release was recently cut.

@fluiddot fluiddot changed the base branch from trunk to gutenberg/after_1.77.0 May 27, 2022 15:00
@fluiddot fluiddot modified the milestones: 20.0, 19.8.1, 20.1 May 27, 2022
@fluiddot fluiddot force-pushed the gutenberg/update/react-native-gesture-handler-2.3.2 branch from 51fa1bf to 4be634f Compare May 27, 2022 17:02
@fluiddot fluiddot merged commit e6a05e6 into gutenberg/after_1.77.0 May 30, 2022
@fluiddot fluiddot deleted the gutenberg/update/react-native-gesture-handler-2.3.2 branch May 30, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants