Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Image block preserves alt text from media library #16787

Merged
merged 7 commits into from
Jun 23, 2022

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jun 21, 2022

Fixes wordpress-mobile/gutenberg-mobile#4977. When the alt text for a media item is present in the media library, copy the alt text into the Image block when the media item is selected. The changes in this PR ensure the alt text value is exposed to the block editor.

To test: See steps outlined in WordPress/gutenberg#41839.

Regression Notes

  1. Potential unintended areas of impact
    Inserting various types of media may break.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested inserting various media blocks within the editor.
  3. What automated tests I added (or what prevented me from doing so)
    None, majority of work and automated testing placed in Gutenberg.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 21, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

When the alt text for a media item is present in the media library, that
value should be copied into the Image block when inserted. This behavior
avoids the need to re-enter the alt text for each image inserted into
the post content.
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 21, 2022

You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr16787-e61f4dc.apk), or scanning this QR code:

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 21, 2022

You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr16787-e61f4dc.apk), or scanning this QR code:

@dcalhoun dcalhoun marked this pull request as ready for review June 21, 2022 19:23
@dcalhoun dcalhoun requested a review from derekblank June 21, 2022 23:37
Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to successfully test this functionality using the native WPAndroid app following the steps here for Image w/ alt text, Video, and File blocks, and did not note any issues from the code. LGTM. 👍

@dcalhoun dcalhoun modified the milestones: 20.2, 20.3 Jun 22, 2022
@dcalhoun dcalhoun changed the base branch from trunk to gutenberg/after_1.79.0 June 23, 2022 18:02
@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused the following dependency changes:

 \--- project :libs:editor:WordPressEditor
-     \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.79.0-alpha1
-          +--- com.facebook.fresco:animated-gif:2.0.0
-          |    +--- com.parse.bolts:bolts-tasks:1.4.0
-          |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.1
-          |    |    +--- com.facebook.soloader:annotation:0.10.1
-          |    |    \--- com.facebook.soloader:nativeloader:0.10.1
-          |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |    \--- com.facebook.fresco:animated-base:2.0.0
-          |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0
-          |         |    +--- com.facebook.infer.annotation:infer-annotation:0.18.0
-          |         |    |    +--- com.google.code.findbugs:jsr305:3.0.1 -> 3.0.2
-          |         |    |    \--- org.jetbrains.kotlin:kotlin-annotations-jvm:1.3.72
-          |         |    +--- com.facebook.soloader:annotation:0.10.1
-          |         |    +--- com.parse.bolts:bolts-tasks:1.4.0
-          |         |    \--- com.facebook.fresco:fbcore:2.5.0
-          |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0
-          |         |    +--- com.facebook.soloader:nativeloader:0.10.1
-          |         |    +--- com.facebook.soloader:annotation:0.10.1
-          |         |    +--- com.parse.bolts:bolts-tasks:1.4.0
-          |         |    +--- com.facebook.fresco:fbcore:2.5.0
-          |         |    \--- com.facebook.fresco:imagepipeline-base:2.5.0 (*)
-          |         +--- com.facebook.fresco:animated-drawable:2.0.0
-          |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
-          |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0
-          |         |    |    +--- com.facebook.fresco:fbcore:2.5.0
-          |         |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-          |         |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0
-          |         |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-          |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
-          |         |    |    |    \--- com.facebook.soloader:soloader:0.10.1 (*)
-          |         |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0
-          |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
-          |         |    |    |    \--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-          |         |    |    +--- com.facebook.fresco:memory-type-native:2.5.0
-          |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
-          |         |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-          |         |    |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
-          |         |    |    |    \--- com.facebook.soloader:nativeloader:0.10.1
-          |         |    |    +--- com.facebook.fresco:memory-type-java:2.5.0
-          |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
-          |         |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-          |         |    |    |    \--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
-          |         |    |    +--- com.facebook.fresco:ui-common:2.5.0
-          |         |    |    |    \--- com.facebook.fresco:fbcore:2.5.0
-          |         |    |    \--- com.facebook.fresco:middleware:2.5.0
-          |         |    |         +--- com.facebook.fresco:fbcore:2.5.0
-          |         |    |         \--- com.facebook.fresco:ui-common:2.5.0 (*)
-          |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |         \--- com.parse.bolts:bolts-tasks:1.4.0
-          +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01 (*)
-          +--- com.facebook.react:react-native:0.66.2
-          |    +--- com.facebook.infer.annotation:infer-annotation:0.18.0 (*)
-          |    +--- com.facebook.yoga:proguard-annotations:1.19.0
-          |    +--- javax.inject:javax.inject:1
-          |    +--- androidx.appcompat:appcompat:1.0.2 -> 1.3.1 (*)
-          |    +--- androidx.autofill:autofill:1.1.0 (*)
-          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
-          |    +--- com.facebook.fresco:fresco:2.5.0
-          |    |    +--- com.facebook.fresco:soloader:2.5.0
-          |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
-          |    |    |    \--- com.facebook.soloader:soloader:0.10.1 (*)
-          |    |    +--- com.facebook.soloader:nativeloader:0.10.1
-          |    |    +--- com.facebook.fresco:ui-common:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:fbcore:2.5.0
-          |    |    +--- com.facebook.fresco:drawee:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:memory-type-native:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:memory-type-java:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:nativeimagefilters:2.5.0
-          |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-          |    |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
-          |    |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0 (*)
-          |    |    |    +--- com.facebook.fresco:memory-type-native:2.5.0 (*)
-          |    |    |    +--- com.facebook.fresco:memory-type-java:2.5.0 (*)
-          |    |    |    +--- com.facebook.soloader:nativeloader:0.10.1
-          |    |    |    +--- com.parse.bolts:bolts-tasks:1.4.0
-          |    |    |    \--- com.facebook.fresco:fbcore:2.5.0
-          |    |    \--- com.facebook.fresco:nativeimagetranscoder:2.5.0
-          |    |         +--- com.facebook.fresco:imagepipeline-base:2.5.0 (*)
-          |    |         +--- com.facebook.soloader:nativeloader:0.10.1
-          |    |         +--- com.parse.bolts:bolts-tasks:1.4.0
-          |    |         \--- com.facebook.fresco:fbcore:2.5.0
-          |    +--- com.facebook.fresco:imagepipeline-okhttp3:2.5.0
-          |    |    +--- com.facebook.fresco:fbcore:2.5.0
-          |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:memory-type-native:2.5.0 (*)
-          |    |    +--- com.facebook.fresco:memory-type-java:2.5.0 (*)
-          |    |    \--- com.squareup.okhttp3:okhttp:3.12.1 -> 4.9.2 (*)
-          |    +--- com.facebook.fresco:ui-common:2.5.0 (*)
-          |    +--- com.facebook.soloader:soloader:0.10.1 (*)
-          |    +--- com.google.code.findbugs:jsr305:3.0.2
-          |    +--- com.squareup.okhttp3:okhttp:4.9.1 -> 4.9.2 (*)
-          |    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.1 -> 4.9.2 (*)
-          |    +--- com.squareup.okio:okio:2.9.0 (*)
-          |    \--- com.facebook.fbjni:fbjni-java-only:0.2.2
-          |         \--- com.facebook.soloader:nativeloader:0.10.1
-          +--- org.wordpress-mobile:react-native-svg:9.13.6
-          |    \--- com.facebook.react:react-native:0.66.2 (*)
-          +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-2
-          |    +--- com.facebook.react:react-native:0.66.2 (*)
-          |    +--- com.google.android.exoplayer:exoplayer:2.13.3
-          |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
-          |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    |    |    \--- com.google.guava:guava:27.1-android
-          |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
-          |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
-          |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
-          |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |         +--- androidx.recyclerview:recyclerview:1.1.0 (*)
-          |    |         \--- androidx.media:media:1.2.1 (*)
-          |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
-          |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
-          |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
-          |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-          |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.9.2 (*)
-          |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.9.2 (*)
-          +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-2
-          |    \--- com.facebook.react:react-native:0.66.2 (*)
-          +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-2
-          |    \--- com.facebook.react:react-native:0.66.2 (*)
-          +--- org.wordpress-mobile:react-native-get-random-values:1.4.0
-          |    \--- com.facebook.react:react-native:0.66.2 (*)
-          +--- org.wordpress-mobile:react-native-masked-view:0.2.6
-          |    \--- com.facebook.react:react-native:0.66.2 (*)
-          +--- org.wordpress-mobile:react-native-screens:2.9.0
-          |    +--- com.facebook.react:react-native:0.66.2 (*)
-          |    +--- androidx.appcompat:appcompat:1.1.0 -> 1.3.1 (*)
-          |    +--- androidx.fragment:fragment:1.2.1 -> 1.4.1 (*)
-          |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
-          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
-          |    \--- com.google.android.material:material:1.1.0 -> 1.6.0-alpha01 (*)
-          +--- org.wordpress-mobile:react-native-safe-area-context:3.2.0
-          |    \--- com.facebook.react:react-native:0.66.2 (*)
-          +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-3
-          +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-2
-          |    +--- com.facebook.react:react-native:0.66.2 (*)
-          |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.3.1 (*)
-          +--- org.wordpress-mobile:react-native-webview:11.6.2
-          |    +--- com.facebook.react:react-native:0.66.2 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.10 (*)
-          +--- org.wordpress-mobile:react-native-clipboard:1.9.0
-          |    \--- com.facebook.react:react-native:0.66.2 (*)
-          +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-1
-          |    +--- com.facebook.react:react-native:0.66.2 (*)
-          |    +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.4.1-wp-3
-          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.3.1 (*)
-          |    +--- androidx.core:core-ktx:1.6.0 -> 1.7.0 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.6.10 (*)
-          +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.79.0-alpha1
-          |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-          |    +--- androidx.gridlayout:gridlayout:1.0.0 (*)
-          |    +--- androidx.cardview:cardview:1.0.0 (*)
-          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.3.1 (*)
-          |    +--- androidx.recyclerview:recyclerview:1.1.0 (*)
-          |    +--- com.facebook.react:react-native:0.66.2 (*)
-          |    +--- org.wordpress:aztec:v1.5.9 (*)
-          |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.5.9 (*)
-          |    +--- org.wordpress.aztec:wordpress-comments:v1.5.9 (*)
-          |    +--- org.wordpress.aztec:glide-loader:v1.5.9
-          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.10 (*)
-          |    |    +--- org.wordpress:aztec:v1.5.9 (*)
-          |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.11.0 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.10 (*)
-          +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.10 (*)
-          \--- org.wordpress-mobile:hermes-release-mirror:0.66.2
+     \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.79.0-alpha2
+          +--- com.facebook.fresco:animated-gif:2.0.0
+          |    +--- com.parse.bolts:bolts-tasks:1.4.0
+          |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.1
+          |    |    +--- com.facebook.soloader:annotation:0.10.1
+          |    |    \--- com.facebook.soloader:nativeloader:0.10.1
+          |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |    \--- com.facebook.fresco:animated-base:2.0.0
+          |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0
+          |         |    +--- com.facebook.infer.annotation:infer-annotation:0.18.0
+          |         |    |    +--- com.google.code.findbugs:jsr305:3.0.1 -> 3.0.2
+          |         |    |    \--- org.jetbrains.kotlin:kotlin-annotations-jvm:1.3.72
+          |         |    +--- com.facebook.soloader:annotation:0.10.1
+          |         |    +--- com.parse.bolts:bolts-tasks:1.4.0
+          |         |    \--- com.facebook.fresco:fbcore:2.5.0
+          |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0
+          |         |    +--- com.facebook.soloader:nativeloader:0.10.1
+          |         |    +--- com.facebook.soloader:annotation:0.10.1
+          |         |    +--- com.parse.bolts:bolts-tasks:1.4.0
+          |         |    +--- com.facebook.fresco:fbcore:2.5.0
+          |         |    \--- com.facebook.fresco:imagepipeline-base:2.5.0 (*)
+          |         +--- com.facebook.fresco:animated-drawable:2.0.0
+          |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+          |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0
+          |         |    |    +--- com.facebook.fresco:fbcore:2.5.0
+          |         |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+          |         |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0
+          |         |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+          |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
+          |         |    |    |    \--- com.facebook.soloader:soloader:0.10.1 (*)
+          |         |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0
+          |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
+          |         |    |    |    \--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+          |         |    |    +--- com.facebook.fresco:memory-type-native:2.5.0
+          |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
+          |         |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+          |         |    |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
+          |         |    |    |    \--- com.facebook.soloader:nativeloader:0.10.1
+          |         |    |    +--- com.facebook.fresco:memory-type-java:2.5.0
+          |         |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
+          |         |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+          |         |    |    |    \--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
+          |         |    |    +--- com.facebook.fresco:ui-common:2.5.0
+          |         |    |    |    \--- com.facebook.fresco:fbcore:2.5.0
+          |         |    |    \--- com.facebook.fresco:middleware:2.5.0
+          |         |    |         +--- com.facebook.fresco:fbcore:2.5.0
+          |         |    |         \--- com.facebook.fresco:ui-common:2.5.0 (*)
+          |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |         \--- com.parse.bolts:bolts-tasks:1.4.0
+          +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01 (*)
+          +--- com.facebook.react:react-native:0.66.2
+          |    +--- com.facebook.infer.annotation:infer-annotation:0.18.0 (*)
+          |    +--- com.facebook.yoga:proguard-annotations:1.19.0
+          |    +--- javax.inject:javax.inject:1
+          |    +--- androidx.appcompat:appcompat:1.0.2 -> 1.3.1 (*)
+          |    +--- androidx.autofill:autofill:1.1.0 (*)
+          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
+          |    +--- com.facebook.fresco:fresco:2.5.0
+          |    |    +--- com.facebook.fresco:soloader:2.5.0
+          |    |    |    +--- com.facebook.fresco:fbcore:2.5.0
+          |    |    |    \--- com.facebook.soloader:soloader:0.10.1 (*)
+          |    |    +--- com.facebook.soloader:nativeloader:0.10.1
+          |    |    +--- com.facebook.fresco:ui-common:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:fbcore:2.5.0
+          |    |    +--- com.facebook.fresco:drawee:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:memory-type-native:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:memory-type-java:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:nativeimagefilters:2.5.0
+          |    |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+          |    |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
+          |    |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0 (*)
+          |    |    |    +--- com.facebook.fresco:memory-type-native:2.5.0 (*)
+          |    |    |    +--- com.facebook.fresco:memory-type-java:2.5.0 (*)
+          |    |    |    +--- com.facebook.soloader:nativeloader:0.10.1
+          |    |    |    +--- com.parse.bolts:bolts-tasks:1.4.0
+          |    |    |    \--- com.facebook.fresco:fbcore:2.5.0
+          |    |    \--- com.facebook.fresco:nativeimagetranscoder:2.5.0
+          |    |         +--- com.facebook.fresco:imagepipeline-base:2.5.0 (*)
+          |    |         +--- com.facebook.soloader:nativeloader:0.10.1
+          |    |         +--- com.parse.bolts:bolts-tasks:1.4.0
+          |    |         \--- com.facebook.fresco:fbcore:2.5.0
+          |    +--- com.facebook.fresco:imagepipeline-okhttp3:2.5.0
+          |    |    +--- com.facebook.fresco:fbcore:2.5.0
+          |    |    +--- com.facebook.fresco:imagepipeline:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:imagepipeline-native:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:memory-type-ashmem:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:memory-type-native:2.5.0 (*)
+          |    |    +--- com.facebook.fresco:memory-type-java:2.5.0 (*)
+          |    |    \--- com.squareup.okhttp3:okhttp:3.12.1 -> 4.9.2 (*)
+          |    +--- com.facebook.fresco:ui-common:2.5.0 (*)
+          |    +--- com.facebook.soloader:soloader:0.10.1 (*)
+          |    +--- com.google.code.findbugs:jsr305:3.0.2
+          |    +--- com.squareup.okhttp3:okhttp:4.9.1 -> 4.9.2 (*)
+          |    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.1 -> 4.9.2 (*)
+          |    +--- com.squareup.okio:okio:2.9.0 (*)
+          |    \--- com.facebook.fbjni:fbjni-java-only:0.2.2
+          |         \--- com.facebook.soloader:nativeloader:0.10.1
+          +--- org.wordpress-mobile:react-native-svg:9.13.6
+          |    \--- com.facebook.react:react-native:0.66.2 (*)
+          +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-2
+          |    +--- com.facebook.react:react-native:0.66.2 (*)
+          |    +--- com.google.android.exoplayer:exoplayer:2.13.3
+          |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
+          |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    |    |    \--- com.google.guava:guava:27.1-android
+          |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
+          |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
+          |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
+          |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |         +--- androidx.recyclerview:recyclerview:1.1.0 (*)
+          |    |         \--- androidx.media:media:1.2.1 (*)
+          |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+          |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
+          |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
+          |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+          |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.9.2 (*)
+          |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.9.2 (*)
+          +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-2
+          |    \--- com.facebook.react:react-native:0.66.2 (*)
+          +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-2
+          |    \--- com.facebook.react:react-native:0.66.2 (*)
+          +--- org.wordpress-mobile:react-native-get-random-values:1.4.0
+          |    \--- com.facebook.react:react-native:0.66.2 (*)
+          +--- org.wordpress-mobile:react-native-masked-view:0.2.6
+          |    \--- com.facebook.react:react-native:0.66.2 (*)
+          +--- org.wordpress-mobile:react-native-screens:2.9.0
+          |    +--- com.facebook.react:react-native:0.66.2 (*)
+          |    +--- androidx.appcompat:appcompat:1.1.0 -> 1.3.1 (*)
+          |    +--- androidx.fragment:fragment:1.2.1 -> 1.4.1 (*)
+          |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
+          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
+          |    \--- com.google.android.material:material:1.1.0 -> 1.6.0-alpha01 (*)
+          +--- org.wordpress-mobile:react-native-safe-area-context:3.2.0
+          |    \--- com.facebook.react:react-native:0.66.2 (*)
+          +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-3
+          +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-2
+          |    +--- com.facebook.react:react-native:0.66.2 (*)
+          |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.3.1 (*)
+          +--- org.wordpress-mobile:react-native-webview:11.6.2
+          |    +--- com.facebook.react:react-native:0.66.2 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.10 (*)
+          +--- org.wordpress-mobile:react-native-clipboard:1.9.0
+          |    \--- com.facebook.react:react-native:0.66.2 (*)
+          +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-1
+          |    +--- com.facebook.react:react-native:0.66.2 (*)
+          |    +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.4.1-wp-3
+          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.3.1 (*)
+          |    +--- androidx.core:core-ktx:1.6.0 -> 1.7.0 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.6.10 (*)
+          +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.79.0-alpha2
+          |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+          |    +--- androidx.gridlayout:gridlayout:1.0.0 (*)
+          |    +--- androidx.cardview:cardview:1.0.0 (*)
+          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.3.1 (*)
+          |    +--- androidx.recyclerview:recyclerview:1.1.0 (*)
+          |    +--- com.facebook.react:react-native:0.66.2 (*)
+          |    +--- org.wordpress:aztec:v1.5.9 (*)
+          |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.5.9 (*)
+          |    +--- org.wordpress.aztec:wordpress-comments:v1.5.9 (*)
+          |    +--- org.wordpress.aztec:glide-loader:v1.5.9
+          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.10 (*)
+          |    |    +--- org.wordpress:aztec:v1.5.9 (*)
+          |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.11.0 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.10 (*)
+          +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.10 (*)
+          \--- org.wordpress-mobile:hermes-release-mirror:0.66.2

Please review and act accordingly

@dcalhoun dcalhoun merged commit 24fd7e2 into gutenberg/after_1.79.0 Jun 23, 2022
@dcalhoun dcalhoun deleted the fix/image-block-preserves-alt-text branch June 23, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Images Inserted From WP Media Library Do Not Contain Already Added Alt Text
3 participants