-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix license directory Linux check #96
Conversation
licensePath = UnityPluginConventions.UNITY_LICENSE_DIRECTORY_MAC_OS | ||
} | ||
else{ | ||
licensePath = new File("") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me check the correct path on Linux
* {@code File} to Unity license directory on macOS. | ||
* @value "/Library/Application Support/Unity/" | ||
*/ | ||
static File UNITY_LICENSE_DIRECTORY_LINUX = new File(".local/share/unity3d/Unity/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to be carefull here. We should use the $HOME
variable or the system property user.home
to create a absolute path based on the user home.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it would be $HOME/shared/... ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no. Either "${System.env("HOME")}/.local/....
or "${System.getProperty("user.home")}/.local/...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SO says the property way is the best
https://stackoverflow.com/a/586345/1380824
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Jenkinsfile
Outdated
@@ -14,7 +14,7 @@ | |||
* See the License for the specific language governing permissions and | |||
* limitations under the License. | |||
*/ | |||
@Library('github.com/wooga/atlas-jenkins-pipeline@1.x') _ | |||
@Library('github.com/wooga/atlas-jenkins-pipeline@1.20.x') _ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be reverted again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
d64384b
to
1747561
Compare
1747561
to
52285c2
Compare
52285c2
to
8fa0963
Compare
Description
The current check fails on the CI for Linux since there's no license directory (it was returning null)
Changes