-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin Rewrite for Gradle 6+ #91
Conversation
ab09c8e
to
1cef5fb
Compare
Update project to Gradle 6.8.3 Rewrite the API's internals
1cef5fb
to
7f5776b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a short look and found two issues from my setup (macOS)
I would also like to see that all *IntergrationTest
classes are renamed back to *IntegrationSpec
. I see these tests more like specifications than plain test files.
import wooga.gradle.unity.UnityTaskIntegrationTest | ||
|
||
class ReturnLicenseTaskIntegrationTest extends UnityTaskIntegrationTest<ReturnLicense> { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed to add these lines since I don't have an active Unity license. So we must trick the system into thinking we have one.
def setup() {
//setup fake license dir so we don't delete actual licenses
def licenseDir = File.createTempDir("unity","testLicenseDir")
createFile("testLicense", licenseDir)
buildFile << """
unity {
licenseDirectory.set(new File("${escapedPath(licenseDir.path)}"))
}
""".stripIndent()
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
"" | true | "${testTaskName}.log" | ||
"" | false | "${testTaskName}.log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two examples error on macOS because the logfile path it prodocues is /${testTaskName}.log
which is not writeable. I couldn't find the logic where the full path gets combined.
8b3b29a
to
ca7a1ef
Compare
Wrap access of project.properties in another provider.
3d55139
to
abb4d3c
Compare
Description
Redesigns the plugin for newer version of Gradle; attempts to simplify the architecture.
To be compatible with newer gradle versions we decided to refactor the whole plugin.
The old architecture of the plugin was quite complex to support batchmode calls from the extension.
This feature is gone as it wasn't really used or had any benifits. The support for unity package creation
is also gone since building and releasing them is no longer a prio.
Changes