-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generateSolution supports unity >= 2022 [ATLAS-1772] #196
Conversation
728c969
to
a2f2198
Compare
…tor', new task type RunCSScript
a2f2198
to
6696136
Compare
f69d7b1
to
a3f0b4e
Compare
So now installing rider becomes a dependency for this task to work, no? There's no guarantee users will have that IDE, and now our agents will need to implicitly install it (though I assume you would manage that). Is that the only external editor package that provided that functionality? |
No, we only need the unity rider upm package, not the editor itself. Rider or VS/VSCode UPM packages would work, but Unity comes with none of them. I used rider as convenience because it was the one package installed in the game I'm using to test this. |
That's good to know. I would update the description to reflect this too. |
src/main/groovy/wooga/gradle/unity/tasks/ExecuteCsharpScript.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/wooga/gradle/unity/tasks/ExecuteCsharpScript.groovy
Outdated
Show resolved
Hide resolved
45a5ac1
to
50f4b35
Compare
Description
FIx the
generateSolution
task to work for unity 2022 and above, due to"UnityEditor.SyncVS.SyncSolution"
not being available anymore on those versions.We now put a script inside of the unity project and run a method in it to generate the solution. It is more complex, but its the more stable solution as it doesn't depend on the project having a specific active external editor. However, we still need to have some external editor UPM package, so we now install the
com.unity.ide.rider
upm package if its not present.To run the script we now have a task to execute scripts in a unity project through a task (RunCSScript).
Changes
generateSolution
not working out of the box on unity 2022 and aboveRunCSScript
task typecom.unity.ide.rider
upm package