Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix predicate for package directory on generate UPM package task #159

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Fix predicate for package directory on generate UPM package task #159

merged 1 commit into from
Jul 4, 2022

Conversation

Azurelol
Copy link
Contributor

@Azurelol Azurelol commented Jul 4, 2022 •
edited
Loading

Description

Fixes the predicate for package directory on the generate upm package task.

Changes

  • FIX Fixes the predicate for package directory on the generate upm package task.

@Azurelol Azurelol requested a review from Larusso as a code owner July 4, 2022 10:29
@Azurelol Azurelol changed the title Fix/generate upm package package dir Fix predicate for package directory on generate UPM package task Jul 4, 2022
@Azurelol Azurelol force-pushed the fix/generate_upm_package_package_dir branch from 7c50264 to 7c2ab35 Compare July 4, 2022 10:32
Larusso
Larusso requested changes Jul 4, 2022
View reviewed changes
Copy link
Member

@Larusso Larusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the imports the rest looks good.

src/integrationTest/groovy/wooga/gradle/unity/UnityPluginIntegrationSpec.groovy Outdated Show resolved Hide resolved
@Azurelol Azurelol requested a review from Larusso July 4, 2022 10:35
@Azurelol Azurelol merged commit daac104 into master Jul 4, 2022
@Azurelol Azurelol deleted the fix/generate_upm_package_package_dir branch July 4, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Larusso Larusso Larusso approved these changes

Assignees
No one assigned
Labels
road to upm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Azurelol @Larusso