Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate solution task up-to-date fix #138

Merged
merged 4 commits into from
Jan 18, 2022
Merged

Conversation

Joaquimmnetto
Copy link
Contributor

@Joaquimmnetto Joaquimmnetto commented Jan 10, 2022

Description

GenerateSolution task was being up-to-date even though it has no inputs and it wasn't meant to be. This happens because of inherited inputs from its parent class.

Ps: this PR is forked from #137

Changes

  • FIX GenerateSolution now is never up-to-date

@Joaquimmnetto Joaquimmnetto self-assigned this Jan 10, 2022
@Joaquimmnetto Joaquimmnetto force-pushed the fix/generate-solution-uptodate branch 2 times, most recently from 3bf0b21 to e2bdd4d Compare January 10, 2022 17:25
@Joaquimmnetto Joaquimmnetto changed the base branch from master to fix/tests-uptodate January 11, 2022 09:45
@Joaquimmnetto Joaquimmnetto force-pushed the fix/generate-solution-uptodate branch 2 times, most recently from f3f0069 to 40c9a6a Compare January 11, 2022 09:53
Base automatically changed from fix/tests-uptodate to master January 18, 2022 12:59
@Larusso Larusso merged commit 18f8818 into master Jan 18, 2022
@Larusso Larusso deleted the fix/generate-solution-uptodate branch January 18, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants