Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UnityBaseSpec trait, now using the BaseSpec from gradle commons #131

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Remove UnityBaseSpec trait, now using the BaseSpec from gradle commons #131

merged 1 commit into from
Apr 21, 2022

Conversation

Azurelol
Copy link
Contributor

@Azurelol Azurelol commented Nov 5, 2021 •
edited by Larusso
Loading

Description

Use the BaseSpec from gradle commons. The old UnityBaseSpec is still preserved to
keep the API stable.

Changes

  • IMPROVE use BaseSpec from gradle commons

@Azurelol Azurelol marked this pull request as draft November 5, 2021 10:34
@Azurelol Azurelol marked this pull request as ready for review November 5, 2021 13:17
@ghost ghost added improve and removed remove update labels Apr 20, 2022
@Larusso Larusso force-pushed the remove/unity_base_spec branch 6 times, most recently from 8c61d0b to e4c182b Compare April 21, 2022 10:24
@Larusso Larusso merged commit 0ae4c7f into master Apr 21, 2022
@Larusso Larusso deleted the remove/unity_base_spec branch April 21, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Larusso Larusso Larusso approved these changes

Assignees
No one assigned
Labels
atlas-stream improve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Azurelol @Larusso