Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Coverage version floor comparison #118

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Fix Coverage version floor comparison #118

merged 1 commit into from
Sep 1, 2021

Conversation

Joaquimmnetto
Copy link
Contributor

@Joaquimmnetto Joaquimmnetto commented Sep 1, 2021 •
edited by Larusso
Loading

Description

Turning on CodeCoverage reporting on Unity 2019 project

unity {
    enableTestCodeCoverage = true
}

adds most code coverage parameters except -enableCodeCoverage.

resolves #117

Changes

  • FIX version number comparison for enableCodeCoverage argument in the Test task .

@Joaquimmnetto Joaquimmnetto self-assigned this Sep 1, 2021
@Joaquimmnetto Joaquimmnetto mentioned this pull request Sep 1, 2021
Closed
@Larusso Larusso merged commit 23a2cf4 into master Sep 1, 2021
@Larusso Larusso deleted the fix/coverage-version-floor branch September 1, 2021 14:50
@Larusso Larusso changed the title FIx: Coverage version floor comparison Fix Coverage version floor comparison Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sebu Sebu Sebu approved these changes

@Larusso Larusso Larusso approved these changes

Assignees

@Joaquimmnetto Joaquimmnetto

Labels
atlas-stream fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enableTestCodeCoverage not setting -enableCodeCoverage on Unity 2019
3 participants
@Joaquimmnetto @Sebu @Larusso