Add new generate solution task #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Azurelol
requested changes
Aug 20, 2021
src/integrationTest/groovy/wooga/gradle/unity/tasks/GenerateSolutionTaskIntegrationSpec.groovy
Show resolved
Hide resolved
src/integrationTest/groovy/wooga/gradle/unity/tasks/GenerateSolutionTaskIntegrationSpec.groovy
Outdated
Show resolved
Hide resolved
Larusso
approved these changes
Aug 20, 2021
Azurelol
reviewed
Aug 20, 2021
src/integrationTest/groovy/wooga/gradle/unity/tasks/GenerateSolutionTaskIntegrationSpec.groovy
Outdated
Show resolved
Hide resolved
| @@ -339,4 +339,13 @@ class UnityPluginIntegrationSpec extends UnityIntegrationSpec { | |||
| result.wasSkipped("returnUnityLicense") | |||
| result.wasExecuted("activateUnity") | |||
| } | |||
|
|
|||
| @UnityPluginTestOptions(forceMockTaskRun = false, disableAutoActivateAndLicense = false) | |||
| def "runs generateSolution task from cli"() { | |||
There was a problem hiding this comment.
I don't the task is necessarily invoked from the CLI. We could use a GUI to have them executed!
There was a problem hiding this comment.
Yeah, in this case, you are right.
There was a problem hiding this comment.
Related to the other conversation:
In this case, we are testing that the generateSolution task is generated by the plugin.
Joaquimmnetto
force-pushed
the
add/generateSolutionTask
branch
from
3f72f23
to
ef6add4
Compare
Azurelol
approved these changes
Aug 20, 2021
Joaquimmnetto
force-pushed
the
add/generateSolutionTask
branch
from
ef6add4
to
b804038
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created new generateSolution task that generates a solution file (if it doesn't exists) by executing Unity's
UnityEditor.SyncVS.SyncSolutionmethod. Its a pretty simple operation, with no parameters needed so there are no properties associated to this task.Changes