Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust-std-esp builder #37

Merged
merged 6 commits into from
Apr 24, 2023
Merged

Conversation

SergioGasquez
Copy link
Contributor

@SergioGasquez SergioGasquez commented Apr 21, 2023

  • Remove fetch.sh for rust-nostd-esp
  • Add rust-std-esp builder
    • It works for all the targets
    • It allows having the Cargo.toml in the project as with no_std
    • I've set ESP_IDF_TOOLS_INSTALL_DIR to global, so esp-idf installation can be reused.
    • I've commented the cargo audit step in compile.sh because esp-idf-hal depends on a time version with vulnerability at the moment:
    Crate:     time
    Version:   0.1.45
    Title:     Potential segfault in the time crate
    Date:      2020-11-18
    ID:        RUSTSEC-2020-0071
    URL:       https://rustsec.org/advisories/RUSTSEC-2020-0071
    Severity:  6.2 (medium)
    Solution:  Upgrade to >=0.2.23
    Dependency tree:
    time 0.1.45
    └── chrono 0.4.24
        └── build-time 0.1.2
            └── esp-idf-sys 0.32.1
                ├── esp32 0.1.0
                ├── esp-idf-svc 0.45.0
                │   └── esp32 0.1.0
                └── esp-idf-hal 0.40.1
                    ├── esp32 0.1.0
                    └── esp-idf-svc 0.45.0
    
    error: 1 vulnerability found!
    

@SergioGasquez SergioGasquez marked this pull request as ready for review April 22, 2023 11:46
@SergioGasquez
Copy link
Contributor Author

I've re-enabled the cargo audit check ignoring the RUSTSEC-2020-0071 vulnerability and added the assets folder required to build the esp-clock project. The esp-clock project with its own Cargo.toml file took about 50 secs to build for the first time.

@urish
Copy link
Contributor

urish commented Apr 22, 2023

So are we good to merge?

@SergioGasquez
Copy link
Contributor Author

So are we good to merge?

Yes! 🚀

@urish urish merged commit 94e4692 into wokwi:main Apr 24, 2023
@SergioGasquez SergioGasquez deleted the feature/std-builder branch April 24, 2023 10:29
@urish
Copy link
Contributor

urish commented Apr 24, 2023

The new build is in production now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants