Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin virtualenv version in lint session #547

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Pin virtualenv version in lint session #547

merged 1 commit into from
Dec 28, 2021

Conversation

FollowTheProcess
Copy link
Collaborator

Closes #545

virtualenv today released 20.11.0 which internally bumps the embedded version of setuptools from 58.3.0 to 59.4.0, which must have contained some breaking change for pre-commit as it depends on virtualenv>=20.0.8 so it would have pulled this latest version in

Pinning virtualenv to 20.10.0 inside the lint session has fixed the issue

@FollowTheProcess FollowTheProcess added bug ci Issues relating to nox's CI pipeline labels Dec 28, 2021
@cjolowicz
Copy link
Collaborator

Great you tracked this down!

I was just going to suggest adding this the env section in the CI workflow:

    VIRTUALENV_SETUPTOOLS: "!=59.4.0"

But this is also good.

@FollowTheProcess
Copy link
Collaborator Author

Great you tracked this down!

I was just going to suggest adding this the env section in the CI workflow:

    VIRTUALENV_SETUPTOOLS: "!=59.4.0"

But this is also good.

Happy to change to that if we want?

@cjolowicz cjolowicz merged commit bbc47b4 into wntrblm:main Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci Issues relating to nox's CI pipeline
Development

Successfully merging this pull request may close these issues.

Strange lint CI failure?
4 participants