Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Sphinx config file #499

Merged
merged 3 commits into from
Oct 13, 2021
Merged

Conversation

DiddiLeija
Copy link
Collaborator

  • Remove a (duplicated?) commentary.
  • Remove the u prefix on strings, since they are set to Unicode by default.

- Remove a (duplicated?) commentary.
- Remove the "u" prefix on strngs, since they are set to Unicode by default.
@DiddiLeija
Copy link
Collaborator Author

If you consider this is unecessary, please tell me 😉.

docs/conf.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DiddiLeija DiddiLeija changed the title Remove redundancies on the Sphinx config file Improve the Sphinx config file Oct 13, 2021
Run black on that file, too.
@DiddiLeija
Copy link
Collaborator Author

I made your suggestions :)

Copy link
Collaborator

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cjolowicz cjolowicz merged commit cbd9d2d into wntrblm:main Oct 13, 2021
@DiddiLeija DiddiLeija deleted the sphinx-conf branch October 13, 2021 18:23
@DiddiLeija
Copy link
Collaborator Author

Thanks everybody! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants