Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore mypy configuration file #402

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Conversation

paw-lu
Copy link
Contributor

@paw-lu paw-lu commented Mar 11, 2021

Nox does not have a mypy.ini or setup.cfg. This will cause mypy to look for configuration files in other directories, which can cause failures when testing locally. This PR adds the --config-file= argument, which tells mypy to ignore config files.


Thanks!

Copy link
Collaborator

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @paw-lu! This LGTM, I'm just wondering if we shouldn't move the mypy command-line options from the Noxfile to our own mypy.ini.

@theacodes
Copy link
Collaborator

Thanks for catching this @paw-lu! This LGTM, I'm just wondering if we shouldn't move the mypy command-line options from the Noxfile to our own mypy.ini.

Maybe, but I think for now we're fine. It'd be a nice follow-up if someone wants to tackle that.

@theacodes theacodes merged commit 5525832 into wntrblm:main Mar 12, 2021
@cjolowicz cjolowicz mentioned this pull request Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants