Added venv params #280
Merged
Added venv params #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Session parameter venv_params has been added as an optional list for virtualenv, venv and conda backends
theacodes
approved these changes
Feb 2, 2020
There was a problem hiding this comment.
This looks great! While reviewing this I noticed that we don't actually document venv_backend at all. Would you be up for a follow-up PR to add documentation for venv_params and venv_backend?
I think it should go after this section: https://nox.thea.codes/en/latest/config.html#configuring-a-session-s-virtualenv
|
Do you want it at the end of that section in that same section or in a new section? |
|
Whichever you think works the best.
…On Sat, Feb 8, 2020, 7:54 AM mostealth ***@***.***> wrote:
Do you want it at the end of that section in that same section or in a new
section?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#280>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB5I43CKC2JP66ULAPMRF3RB3ISXANCNFSM4KOTADUA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session parameter venv_params has been added as an optional list for virtualenv, venv and conda backends