Add interactive property to session. #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attribute session and tests for attribute.
theacodes
reviewed
May 22, 2019
nox/sessions.py
Outdated
| @@ -115,6 +116,11 @@ def bin(self): | |||
| """The bin directory for the virtualenv.""" | |||
| return self._runner.venv.bin | |||
|
|
|||
| @property | |||
| def interactive(self): | |||
| """Boolean showing if the session was ran in an interactive sessions.""" | |||
There was a problem hiding this comment.
Use active voice, please: True if the Nox is being run in an interactive session or False otherwise.
There was a problem hiding this comment.
Just changed it in the latest commit
tests/test_sessions.py
Outdated
| @@ -83,6 +83,21 @@ def test_properties(self): | |||
| assert session.bin is runner.venv.bin | |||
| assert session.python is runner.func.python | |||
|
|
|||
| def test_interactive(self): | |||
| with mock.patch("nox.sessions.sys") as mock_sys: | |||
There was a problem hiding this comment.
Is it possible to just patch sys.stdout.istty?
There was a problem hiding this comment.
Yep. I just pushed a commit with the change.
|
This is wonderful, @AGeekInside. I'm going to merge #187 first and add a |
theacodes
changed the title
stsewd
reviewed
May 26, 2019
Co-Authored-By: Santos Gallegos <santos_g@outlook.com>
theacodes
changed the title
|
Thank you, @AGeekInside! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a stab at adding the interactive attribute to session. The tests are present, but I think it'll need some testing in a non-interactive pipeline to confirm it works. The unit tests in test_sessions feel a bit clunky with the mocks, so suggestions on making that cleaner would be great.
I need to sort out how to update the docs as well to include the new attribute.
If this looks reasonable to folks, I can take a look at adding the '--non-interactive' flag.