Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow session.install and session.conda_install to run when no venv backend is set #318

Closed
smarie opened this issue Apr 22, 2020 · 0 comments · Fixed by #316
Closed

Allow session.install and session.conda_install to run when no venv backend is set #318

smarie opened this issue Apr 22, 2020 · 0 comments · Fixed by #316

Comments

@smarie
Copy link
Contributor

smarie commented Apr 22, 2020

As of now, when no venv backend is set (either through python=False or by setting the venv to 'none'), users get a ValueError when trying to install or conda_install.

In some cases (See also #301 ) this would be actually useful.

smarie pushed a commit to smarie/nox that referenced this issue Apr 22, 2020
…(or python=False). Previously a `ValueError` was raised. Fixes wntrblm#318
theacodes pushed a commit that referenced this issue May 24, 2020
* New global option `nox.options.venv_backend` to set the default backend. Fixes #315

* Added doc about the new option

* Blackened

* fixed tests

* Fixed docs

* Fixed coverage by adding tests for the venv_backend_completer

* fixed test

* Added tests for short and long versions of the new option.

* Replaced the venv_backend completer with a simple `choices` from argparse :)

* Renamed venv_backend to default_venv_backend, and created new force_venv_backend

* New "none" choice for venv_backends, equivalent to python=False

* Updated doc concerning default_venv_backend and force_venv_backend, as well as the new 'none' backend

* Fixed all manifest tests

* Fixed test_tasks for venv_backend

* Fixed coverage

* Blackened code

* The warning message was appearing for all sessions, even those deselected. It is now only logged when session is run.

* Added `--no-venv` option. Fixes #301

* Blackened

* Fixed tests

* Improved coverage

* Blackened

* Fixed an issue with parametrization: warning would not be issued. Added corresponding tests. This should make coverage happy, too.

* Blackened

* Now `install` and `conda_install` work when there is no venv backend (or python=False). Previously a `ValueError` was raised. Fixes #318

* Fixed test

* Minor edit to trigger CI build again as it seems stuck.

* Minor doc fix to trigger the CI again (appveyor false fail)

Co-authored-by: Sylvain MARIE <sylvain.marie@se.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant