-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build performance optimizations #2171
Conversation
🦋 Changeset detectedLatest commit: af29d34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
~8x faster in a micro benchmark: 13.2 million ops/sec vs 1.7 million ops/sec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely changes 🔥
Description
.replace()
with a regular expressionstripExtension()
utility in sidebar generation to use lower-level string operations instead of a regular expression in.replace()
. (In this case the logic is technically subtly different as the RegExp was matching\w+
after a final period, but given the limited scope of usage for this utility on file paths ending in.md
,.mdx
etc., it should be fine.)slugToParam()
utility to avoid an unnecessary.replace()
in favour of a faster.slice()
linkFromInternalSidebarLinkItem()
to avoid the need to.replace()
entirely