Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docs for json schemas #8705

Merged
merged 15 commits into from
Jul 31, 2024
Merged

feat: add docs for json schemas #8705

merged 15 commits into from
Jul 31, 2024

Conversation

alexanderniebuhr
Copy link
Member

Description (required)

This PR adds docs for the following Core PR: withastro/astro#11379

The feature was experimental before:

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 4.12. See astro PR #11379.

This comment was marked as outdated.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 30, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/content-collections.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Jul 2, 2024
@sarah11918
Copy link
Member

Hey @alexanderniebuhr ! I looked at the core astro PR and looks like there might still be some questions there about the implementation?

Since I don't see discussion/confirmation there yet that this feature is "in its final form", just a heads up that I'll wait to review (both of these PRs) until I know this is what the feature will look like for sure! Don't hesitate to ping me when it's time for me to really take a close look OR if you have specific questions about the feature you'd like my input on while it's being finalized! 🙌

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexanderniebuhr ! Always nice to get features out of experimental and properly into docs! That means the docs have a slightly higher standard, so I've left some comments, including a question for how we introduce the purpose of this feature! 🙌

src/content/docs/en/guides/content-collections.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/content-collections.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/content-collections.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/content-collections.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/content-collections.mdx Outdated Show resolved Hide resolved
@alexanderniebuhr
Copy link
Member Author

Thanks for your review. It's a while back, since my last docs work.. so yeah need to reactivate this knowledge 🤷

alexanderniebuhr and others added 3 commits July 2, 2024 20:22
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@sarah11918
Copy link
Member

Looks like Matthew wants this one for 4.13, fyi!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, clicked start a review instead of comment, and I don't think I can cancel this. Just meant to add on another comment to our thread!

src/content/docs/en/guides/content-collections.mdx Outdated Show resolved Hide resolved
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alexanderniebuhr ! I consider this one ready to go whenever the feature is released (which I think is scheduled for 4.13) 🙌

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jul 8, 2024
Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 9e7f8b0
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66aa475752f5770008eecad5
😎 Deploy Preview https://deploy-preview-8705--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alexanderniebuhr
Copy link
Member Author

@sarah11918 updated docs, after the config flag was removed from the core PR

@sarah11918 sarah11918 added this to the 4.13 milestone Jul 24, 2024
@sarah11918
Copy link
Member

Thanks @alexanderniebuhr for the ping! Still approved by me, and I've gone and commented in the other astro PR for help drafting the changeset, which I'll review after you put something together!

@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! label Jul 24, 2024
@sarah11918 sarah11918 changed the base branch from main to 4.13.0 July 31, 2024 14:17
@sarah11918 sarah11918 merged commit 6ce0c09 into 4.13.0 Jul 31, 2024
1 check passed
@sarah11918 sarah11918 deleted the ccjsonschema branch July 31, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants