-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add docs for json schemas #8705
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Hey @alexanderniebuhr ! I looked at the core astro PR and looks like there might still be some questions there about the implementation? Since I don't see discussion/confirmation there yet that this feature is "in its final form", just a heads up that I'll wait to review (both of these PRs) until I know this is what the feature will look like for sure! Don't hesitate to ping me when it's time for me to really take a close look OR if you have specific questions about the feature you'd like my input on while it's being finalized! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alexanderniebuhr ! Always nice to get features out of experimental and properly into docs! That means the docs have a slightly higher standard, so I've left some comments, including a question for how we introduce the purpose of this feature! 🙌
Thanks for your review. It's a while back, since my last docs work.. so yeah need to reactivate this knowledge 🤷 |
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Looks like Matthew wants this one for 4.13, fyi! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, clicked start a review instead of comment, and I don't think I can cancel this. Just meant to add on another comment to our thread!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @alexanderniebuhr ! I consider this one ready to go whenever the feature is released (which I think is scheduled for 4.13) 🙌
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@sarah11918 updated docs, after the config flag was removed from the core PR |
Thanks @alexanderniebuhr for the ping! Still approved by me, and I've gone and commented in the other astro PR for help drafting the changeset, which I'll review after you put something together! |
Description (required)
This PR adds docs for the following Core PR: withastro/astro#11379
The feature was experimental before:
Related issues & labels (optional)
For Astro version:
4.12
. See astro PR #11379.