-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18nIgnore] Fix highlighted code errors #5817
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Not sure if I should probably update translations, if they exist... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Usually we suggest avoiding updating multiple languages at once, but for a small fix like this, if you can fix all other languages where this is present, that would also be acceptable (and we’d stick the i18nIgnore
keyword into the commit message to avoid triggering translation status changes).
@delucis done all other languages, the issue was that some space was added (or removed) and the numbers didn't align. Found a language which had numbers wrong even more ahah Do check that the commit message is correct with the correct usage of the keyword.
I asked because of this, I know the policy, which makes sense, but it was such a small fix... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @itsmatteomanf! Noticed one of these that looks off.
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
I accepted it... but locally looks like this. VSCode doesn't handle it, as it doesn't align with what it has locally, as you are asking to change it how it already is ahah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Fixes a small issue in rows selected in a code block, off-by-one errors.