Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update astro-components.mdx #5712

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

alexnguyennz
Copy link
Contributor

Description (required)

spaces, semicolons, quotes for consistency

Copy link

vercel bot commented Dec 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 11, 2023 3:35pm

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarah11918 sarah11918 added code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Dec 11, 2023
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this @alexnguyennz 🙌

@yanthomasdev yanthomasdev merged commit 3dfbaf4 into withastro:main Dec 11, 2023
6 checks passed
ematipico pushed a commit that referenced this pull request Jan 26, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Sep 21, 2024
* Use `props` with feminine form (`une propriété`)
* Replace singular `prop` with `property`
* Reword some sentences/Fix typo
* Use French quotes
* Add missing changes from withastro#6793 and withastro#5712
yanthomasdev added a commit that referenced this pull request Sep 23, 2024
… translation (#9463)

* i18n(fr): update `basics/astro-components.mdx`

* Use `props` with feminine form (`une propriété`)
* Replace singular `prop` with `property`
* Reword some sentences/Fix typo
* Use French quotes
* Add missing changes from #6793 and #5712

* i18n(fr): update `guides/cms/apostrophecms.mdx`

* Make usage of `props`/`property` consistent
* Fix some typo
* Translate in French an untranslated part

* i18n(fr): make usage of props/prop consistent

* fix anchor link in `typescript.mdx`

---------

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants