Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Partytown from hijacking history API #9419

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Prevent Partytown from hijacking history API #9419

merged 3 commits into from
Dec 14, 2023

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Dec 12, 2023

Changes

Testing

  • Manually

Docs

N/A, bug fix

Copy link

changeset-bot bot commented Dec 12, 2023

🦋 Changeset detected

Latest commit: b645a85

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthewp
Copy link
Contributor Author

!preview vt-partytown

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Dec 12, 2023
Copy link
Contributor

Snapshots have been released for the following packages:

  • astro@experimental--vt-partytown
  • @astrojs/lit@experimental--vt-partytown
  • @astrojs/vercel@experimental--vt-partytown
Publish Log
🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the experimental--vt-partytown tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info astro
🦋  info npm info @astrojs/prism
🦋  info npm info @astrojs/rss
🦋  info npm info create-astro
🦋  info npm info @astrojs/alpinejs
🦋  info npm info @astrojs/lit
🦋  info npm info @astrojs/markdoc
🦋  info npm info @astrojs/mdx
🦋  info npm info @astrojs/node
🦋  info npm info @astrojs/partytown
🦋  info npm info @astrojs/preact
🦋  info npm info @astrojs/react
🦋  info npm info @astrojs/sitemap
🦋  info npm info @astrojs/solid-js
🦋  info npm info @astrojs/svelte
🦋  info npm info @astrojs/tailwind
🦋  info npm info @astrojs/vercel
🦋  info npm info @astrojs/vue
🦋  info npm info @astrojs/internal-helpers
🦋  info npm info @astrojs/markdown-remark
🦋  info npm info @astrojs/telemetry
🦋  info npm info @astrojs/underscore-redirects
🦋  info npm info @astrojs/upgrade
🦋  info astro is being published because our local version (0.0.0-vt-partytown-20231212203707) has not been published on npm
🦋  warn @astrojs/prism is not being published because version 3.0.0 is already published on npm
🦋  warn @astrojs/rss is not being published because version 4.0.1 is already published on npm
🦋  warn create-astro is not being published because version 4.5.2 is already published on npm
🦋  warn @astrojs/alpinejs is not being published because version 0.3.1 is already published on npm
🦋  info @astrojs/lit is being published because our local version (0.0.0-vt-partytown-20231212203707) has not been published on npm
🦋  warn @astrojs/markdoc is not being published because version 0.8.0 is already published on npm
🦋  warn @astrojs/mdx is not being published because version 2.0.1 is already published on npm
🦋  warn @astrojs/node is not being published because version 7.0.1 is already published on npm
🦋  warn @astrojs/partytown is not being published because version 2.0.2 is already published on npm
🦋  warn @astrojs/preact is not being published because version 3.0.1 is already published on npm
🦋  warn @astrojs/react is not being published because version 3.0.7 is already published on npm
🦋  warn @astrojs/sitemap is not being published because version 3.0.3 is already published on npm
🦋  warn @astrojs/solid-js is not being published because version 3.0.2 is already published on npm
🦋  warn @astrojs/svelte is not being published because version 5.0.1 is already published on npm
🦋  warn @astrojs/tailwind is not being published because version 5.0.3 is already published on npm
🦋  info @astrojs/vercel is being published because our local version (0.0.0-vt-partytown-20231212203707) has not been published on npm
🦋  warn @astrojs/vue is not being published because version 4.0.3 is already published on npm
🦋  warn @astrojs/internal-helpers is not being published because version 0.2.1 is already published on npm
🦋  warn @astrojs/markdown-remark is not being published because version 4.0.1 is already published on npm
🦋  warn @astrojs/telemetry is not being published because version 3.0.4 is already published on npm
🦋  warn @astrojs/underscore-redirects is not being published because version 0.3.3 is already published on npm
🦋  warn @astrojs/upgrade is not being published because version 0.2.1 is already published on npm
🦋  info Publishing "astro" at "0.0.0-vt-partytown-20231212203707"
🦋  info Publishing "@astrojs/lit" at "0.0.0-vt-partytown-20231212203707"
🦋  info Publishing "@astrojs/vercel" at "0.0.0-vt-partytown-20231212203707"
🦋  success packages published successfully:
🦋  astro@0.0.0-vt-partytown-20231212203707
🦋  @astrojs/lit@0.0.0-vt-partytown-20231212203707
🦋  @astrojs/vercel@0.0.0-vt-partytown-20231212203707
🦋  Creating git tags...
🦋  New tag:  astro@0.0.0-vt-partytown-20231212203707
🦋  New tag:  @astrojs/lit@0.0.0-vt-partytown-20231212203707
🦋  New tag:  @astrojs/vercel@0.0.0-vt-partytown-20231212203707
Build Log

> root@0.0.0 build /home/runner/work/astro/astro
> turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*"

• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/internal-helpers, @astrojs/lit, @astrojs/markdoc, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/underscore-redirects, @astrojs/upgrade, @astrojs/vercel, @astrojs/vue, @benchmark/timer, astro, create-astro
• Running build in 26 packages
• Remote caching enabled
::group::@astrojs/upgrade:build
cache hit, suppressing logs 2a93542d95491830
::endgroup::
::group::@astrojs/prism:build
cache hit, suppressing logs 81bed5c056d4b29d
::endgroup::
::group::@astrojs/telemetry:build
cache hit, suppressing logs 20dce2800041ecab
::endgroup::
::group::create-astro:build
cache hit, suppressing logs a26580f945cb8884
::endgroup::
::group::@astrojs/internal-helpers:build
cache hit, suppressing logs eac91336501ec7d9
::endgroup::
::group::@astrojs/markdown-remark:build
cache miss, executing 5ba3dfef4a1c58aa

> @astrojs/markdown-remark@4.0.1 build /home/runner/work/astro/astro/packages/markdown/remark
> astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json

::endgroup::
::group::astro:build
cache miss, executing 0c7afecd69f5421e

> astro@0.0.0-vt-partytown-20231212203707 build /home/runner/work/astro/astro/packages/astro
> pnpm run prebuild && astro-scripts build "src/**/*.{ts,js}" && tsc && pnpm run postbuild


> astro@0.0.0-vt-partytown-20231212203707 prebuild /home/runner/work/astro/astro/packages/astro
> astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts"


> astro@0.0.0-vt-partytown-20231212203707 postbuild /home/runner/work/astro/astro/packages/astro
> astro-scripts copy "src/**/*.astro" && astro-scripts copy "src/**/*.wasm"

::endgroup::
::group::@astrojs/alpinejs:build
cache miss, executing bf2a74e4e74c78e1

> @astrojs/alpinejs@0.3.1 build /home/runner/work/astro/astro/packages/integrations/alpinejs
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/partytown:build
cache miss, executing dc2f3f0e262e9143

> @astrojs/partytown@2.0.2 build /home/runner/work/astro/astro/packages/integrations/partytown
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/underscore-redirects:build
cache miss, executing 660ccbbf9131f78f

> @astrojs/underscore-redirects@0.3.3 build /home/runner/work/astro/astro/packages/underscore-redirects
> astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json

::endgroup::
::group::@astrojs/solid-js:build
cache miss, executing 94312947f105d878

> @astrojs/solid-js@3.0.2 build /home/runner/work/astro/astro/packages/integrations/solid
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/lit:build
cache miss, executing 89404d7bcb5dbd9e

> @astrojs/lit@0.0.0-vt-partytown-20231212203707 build /home/runner/work/astro/astro/packages/integrations/lit
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/rss:build
cache miss, executing fc97834d39df2718

> @astrojs/rss@4.0.1 build /home/runner/work/astro/astro/packages/astro-rss
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/vercel:build
cache miss, executing 708b9d71a63aa675

> @astrojs/vercel@0.0.0-vt-partytown-20231212203707 build /home/runner/work/astro/astro/packages/integrations/vercel
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/node:build
cache miss, executing e1e7b495930bc6fa

> @astrojs/node@7.0.1 build /home/runner/work/astro/astro/packages/integrations/node
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/preact:build
cache miss, executing 414b48a1d3dce3be

> @astrojs/preact@3.0.1 build /home/runner/work/astro/astro/packages/integrations/preact
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/svelte:build
cache miss, executing a6a657af40fe21fd

> @astrojs/svelte@5.0.1 build /home/runner/work/astro/astro/packages/integrations/svelte
> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc

::endgroup::
::group::@astrojs/tailwind:build
cache miss, executing 8776354b7e0600ca

> @astrojs/tailwind@5.0.3 build /home/runner/work/astro/astro/packages/integrations/tailwind
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/react:build
cache miss, executing 5e748b38b0bbabbc

> @astrojs/react@3.0.7 build /home/runner/work/astro/astro/packages/integrations/react
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@benchmark/timer:build
cache miss, executing 81f8e46cd1343960

> @benchmark/timer@0.0.0 build /home/runner/work/astro/astro/benchmark/packages/timer
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/markdoc:build
cache miss, executing 92d521a6a50387d1

> @astrojs/markdoc@0.8.0 build /home/runner/work/astro/astro/packages/integrations/markdoc
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/sitemap:build
cache miss, executing 724e8658607d8e3e

> @astrojs/sitemap@3.0.3 build /home/runner/work/astro/astro/packages/integrations/sitemap
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/mdx:build
cache miss, executing fc9d8eed4606c301

> @astrojs/mdx@2.0.1 build /home/runner/work/astro/astro/packages/integrations/mdx
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/vue:build
cache miss, executing 485154033d47c5ff

> @astrojs/vue@4.0.3 build /home/runner/work/astro/astro/packages/integrations/vue
> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc

::endgroup::

 Tasks:    24 successful, 24 total
Cached:    5 cached, 24 total
  Time:    40.824s 

Copy link
Member

@martrapp martrapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/astro/src/transitions/router.ts Show resolved Hide resolved
@matthewp matthewp marked this pull request as ready for review December 14, 2023 15:12
@matthewp matthewp merged commit 151bd42 into main Dec 14, 2023
13 checks passed
@matthewp matthewp deleted the partytown-vt branch December 14, 2023 15:20
@astrobot-houston astrobot-houston mentioned this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partytown breaks VT fallback
2 participants